Re: [RESEND PATCH v7 0/7] Rockchip dw-mipi-dsi driver

From: Chris Zhong
Date: Wed Feb 22 2017 - 19:27:09 EST



On 02/23/2017 06:10 AM, Sean Paul wrote:
On Wed, Feb 22, 2017 at 1:55 PM, John Keeping <john@xxxxxxxxxxxx> wrote:
On Wed, 22 Feb 2017 10:57:05 -0500, Sean Paul wrote:

On Wed, Feb 22, 2017 at 8:43 AM, John Keeping <john@xxxxxxxxxxxx> wrote:
On Tue, 21 Feb 2017 10:39:18 -0500, Sean Paul wrote:

On Mon, Feb 20, 2017 at 04:02:16PM +0800, Chris Zhong wrote:
Hi all

[Resend this v7 version series, since there are 5 mails have gone missing, last
week]

This version does not change the existing v6 patches, just to add the
"bandwidth fix" patch back, since we really need it.

This patch serial is for RK3399 MIPI DSI. The MIPI DSI controller of
RK3399 is almost the same as RK3288, except a little bit of difference
in phy clock controlling and port id selection register. These patches
add RK3399 support and the power domain support.

And these patches base on John Keeping's v3 patches[0], it fixes many bugs,
they have been tested on rk3288 evb board.
Do we have an ETA on when John is planning on respinning his patchset based on
review feedback?
I have all of the changes queued but I was hoping to find some time to
test the latest version before sending it out; unfortunately everything
else is more important at the moment. If you're happy with the caveat
that the latest changes are build tested only I can probably send it
out this afternoon.
I suppose my answer depends on when the tested version will be
available, or perhaps Chris can test the new set for you? I don't have
any rockchip devices with mipi, so i'm not much help.
None of the changes scare me that much, so I don't expect testing to
throw up any problems but I don't like throwing out patches without at
least a basic test run.

Agreed. I don't think we're in such desperate need that we should
forego testing. If Chris can provide Tested-by, you should send them
out, otherwise I'm happy to wait.

Thanks for the update,

Sean

Sure, I am very glad to test them.
Actually, I have picked the v3 patches to cros kernel (changed a little bit).
So far, my 2 mipi dsi panels works well. The cros patches:
https://chromium-review.googlesource.com/#/c/430596/
...
https://chromium-review.googlesource.com/#/c/442347/


I might have time to test on Friday, but I expect Chris has more time to
devote to this than I do, so maybe it's better if I send the patches out
tomorrow.


John



--
Chris Zhong