Re: [PATCH 1/4] fs, afs: convert afs_cell.usage from atomic_t to refcount_t

From: David Howells
Date: Wed Feb 22 2017 - 12:29:30 EST


Reshetova, Elena <elena.reshetova@xxxxxxxxx> wrote:

> Thank you very much David for testing the patches!
> I guess for this one and other two patches it means that if we want to do the atomic_t --> refcount_t conversions,
> we need to do +1 on the whole counting scheme to avoid issues around reaching zero.
> Do you see this approach reasonable? I can give it a try, if it makes sense in your opinion.

Or you could create a refcount_inc_may_resurrect() function that does allow
increment from 0. Make it take a lock-check like the rcu functions do.

David