Re: [PATCH/RFC 3/6] drivers: firmware: psci: Implement shallow suspend mode

From: Sudeep Holla
Date: Wed Feb 22 2017 - 09:36:02 EST




On 22/02/17 13:47, Geert Uytterhoeven wrote:
> Hi Sudeep,
>
> On Tue, Feb 21, 2017 at 6:22 PM, Sudeep Holla <sudeep.holla@xxxxxxx> wrote:

[...]

>>
>> IIUC, it's not implemented today. I can't talk about future ;), but your
>
> Good, so there's no need for the DT property, and drivers/firmware/psci.c
> should aways call do_cpu_idle() instead of PSCI SYSTEM_SUSPEND if any
> other wake-up sources are configured?
>

No.

> That follows the principle of least surprise: it doesn't leave the user with
> a system that won't wake up the way he configured it to wake up.
>

But he can still wake up with the "switch" so there's no surprise. He
just need to better understand his system before playing with it ;)

--
Regards,
Sudeep