Re: [Outreachy kernel] [PATCH 4/6] staging: Drop useless initialisation

From: Julia Lawall
Date: Tue Feb 21 2017 - 12:59:11 EST

Next message: Luis R. Rodriguez: "Re: [PATCH 1/2] firmware: add more flexible request_firmware_async function"
Previous message: Jonathan Dieter: "[PATCH v2 2/2] usbip: Fix implicit fallthrough warning"
In reply to: Julia Lawall: "Re: [Outreachy kernel] [PATCH 4/6] staging: Drop useless initialisation"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

> Also, note that the above semantic patch is not completely safe,
> because
> the code could be, eg:
>
> int a = 0;
> a = a + 1;
>
> In that case, the initialization of a would be needed. ÂYou
> should check
> each case for this issue.
>
>
> I have checked that case before sending the patch by diff .

OK, good :)

> Should I cut this patch as a totally different patch series and do I haveÂ
> to mention v2.
>
> ÂIf I have to mention v2 then how will I relate that new patch series with
> thisÂ
> particular patch.

It's true that the subject lines will be completely different. Maybe just
respond to your previous patch and say to ignore it, and then start over
with these patches, with one patch per driver.

julia

> Thanks,
> Simran
> Â
>
> julia
>
> > Signed-off-by: simran singhal <singhal...@xxxxxxxxx>
> > ---
> > Âdrivers/staging/android/ion/ion_heap.c Â Â Â Â Â Â Â| 2 +-
> > Âdrivers/staging/gdm724x/gdm_lte.c Â Â Â Â Â Â Â Â Â | 2 +-
> > Âdrivers/staging/gdm724x/gdm_mux.c Â Â Â Â Â Â Â Â Â | 4 ++--
> > Âdrivers/staging/iio/addac/adt7316-i2c.c Â Â Â Â Â Â | 2 +-
> > Âdrivers/staging/lustre/lustre/ldlm/ldlm_request.c Â | 2 +-
> > Âdrivers/staging/lustre/lustre/obdclass/cl_page.c Â Â| 2 +-
> > Âdrivers/staging/media/s5p-cec/exynos_hdmi_cecctrl.c | 2 +-
> > Âdrivers/staging/media/s5p-cec/s5p_cec.c Â Â Â Â Â Â | 2 +-
> > Âdrivers/staging/rtl8188eu/core/rtw_ap.c Â Â Â Â Â Â | 4 ++--
> > Âdrivers/staging/rtl8188eu/core/rtw_efuse.c Â Â Â Â Â| 2 +-
> > Âdrivers/staging/rtl8188eu/core/rtw_mlme_ext.c Â Â Â | 2 +-
> > Âdrivers/staging/rtl8188eu/core/rtw_recv.c Â Â Â Â Â | 4 ++--
> > Âdrivers/staging/rtl8188eu/core/rtw_sreset.c Â Â Â Â | 2 +-
> > Âdrivers/staging/rtl8188eu/core/rtw_wlan_util.c Â Â Â| 2 +-
> > Âdrivers/staging/rtl8188eu/core/rtw_xmit.c Â Â Â Â Â | 2 +-
> > Âdrivers/staging/rtl8188eu/hal/hal_intf.c Â Â Â Â Â Â| 2 +-
> > Âdrivers/staging/rtl8188eu/os_dep/ioctl_linux.c Â Â Â| 2 +-
> > Âdrivers/staging/rtl8188eu/os_dep/xmit_linux.c Â Â Â | 2 +-
> > Âdrivers/staging/rtl8712/rtl8712_xmit.c Â Â Â Â Â Â Â| 2 +-
> > Âdrivers/staging/rtl8712/rtl871x_mp.c Â Â Â Â Â Â Â Â| 6
> +++---
> > Âdrivers/staging/rts5208/rtsx_chip.c Â Â Â Â Â Â Â Â | 2 +-
> > Âdrivers/staging/rts5208/sd.c Â Â Â Â Â Â Â Â Â Â Â Â| 4 ++--
> > Âdrivers/staging/sm750fb/ddk750_chip.c Â Â Â Â Â Â Â | 2 +-
> > Âdrivers/staging/sm750fb/ddk750_power.c Â Â Â Â Â Â Â| 2 +-
> > Âdrivers/staging/speakup/speakup_ltlk.c Â Â Â Â Â Â Â| 2 +-
> > Âdrivers/staging/unisys/visorbus/visorchipset.c Â Â Â| 4 ++--
> > Âdrivers/staging/wlan-ng/cfg80211.c Â Â Â Â Â Â Â Â Â| 2 +-
> > Âdrivers/staging/xgifb/XGI_main_26.c Â Â Â Â Â Â Â Â | 2 +-
> > Â28 files changed, 35 insertions(+), 35 deletions(-)
> >
> > diff --git a/drivers/staging/android/ion/ion_heap.c
> b/drivers/staging/android/ion/ion_heap.c
> > index 4e5c0f1..4bd844b 100644
> > --- a/drivers/staging/android/ion/ion_heap.c
> > +++ b/drivers/staging/android/ion/ion_heap.c
> > @@ -270,7 +270,7 @@ static unsigned long
> ion_heap_shrink_count(struct shrinker *shrinker,
> > Â{
> > ÂÂÂÂÂÂÂÂÂstruct ion_heap *heap = container_of(shrinker, struct
> ion_heap,
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ Â Â shrinker);
> > -ÂÂÂÂÂÂÂÂint total = 0;
> > +ÂÂÂÂÂÂÂÂint total;
> >
> > ÂÂÂÂÂÂÂÂÂtotal = ion_heap_freelist_size(heap) / PAGE_SIZE;
> > ÂÂÂÂÂÂÂÂÂif (heap->ops->shrink)
> > diff --git a/drivers/staging/gdm724x/gdm_lte.c
> b/drivers/staging/gdm724x/gdm_lte.c
> > index a182757..e0f0912 100644
> > --- a/drivers/staging/gdm724x/gdm_lte.c
> > +++ b/drivers/staging/gdm724x/gdm_lte.c
> > @@ -353,7 +353,7 @@ static s32 gdm_lte_tx_nic_type(struct
> net_device *dev, struct sk_buff *skb)
> > ÂÂÂÂÂÂÂÂÂstruct ipv6hdr *ipv6;
> > ÂÂÂÂÂÂÂÂÂint mac_proto;
> > ÂÂÂÂÂÂÂÂÂvoid *network_data;
> > -ÂÂÂÂÂÂÂÂu32 nic_type = 0;
> > +ÂÂÂÂÂÂÂÂu32 nic_type;
> >
> > ÂÂÂÂÂÂÂÂÂ/* NIC TYPE is based on the nic_id of this net_device
> */
> > ÂÂÂÂÂÂÂÂÂnic_type = 0x00000010 | nic->nic_id;
> > diff --git a/drivers/staging/gdm724x/gdm_mux.c
> b/drivers/staging/gdm724x/gdm_mux.c
> > index 4009691..aba32e2 100644
> > --- a/drivers/staging/gdm724x/gdm_mux.c
> > +++ b/drivers/staging/gdm724x/gdm_mux.c
> > @@ -62,7 +62,7 @@ static int packet_type_to_index(u16
> packetType)
> >
> > Âstatic struct mux_tx *alloc_mux_tx(int len)
> > Â{
> > -ÂÂÂÂÂÂÂÂstruct mux_tx *t = NULL;
> > +ÂÂÂÂÂÂÂÂstruct mux_tx *t;
> >
> > ÂÂÂÂÂÂÂÂÂt = kzalloc(sizeof(*t), GFP_ATOMIC);
> > ÂÂÂÂÂÂÂÂÂif (!t)
> > @@ -91,7 +91,7 @@ static void free_mux_tx(struct mux_tx *t)
> >
> > Âstatic struct mux_rx *alloc_mux_rx(void)
> > Â{
> > -ÂÂÂÂÂÂÂÂstruct mux_rx *r = NULL;
> > +ÂÂÂÂÂÂÂÂstruct mux_rx *r;
> >
> > ÂÂÂÂÂÂÂÂÂr = kzalloc(sizeof(*r), GFP_KERNEL);
> > ÂÂÂÂÂÂÂÂÂif (!r)
> > diff --git a/drivers/staging/iio/addac/adt7316-i2c.c
> b/drivers/staging/iio/addac/adt7316-i2c.c
> > index f66dd3e..af56dba 100644
> > --- a/drivers/staging/iio/addac/adt7316-i2c.c
> > +++ b/drivers/staging/iio/addac/adt7316-i2c.c
> > @@ -41,7 +41,7 @@ static int adt7316_i2c_read(void *client, u8
> reg, u8 *data)
> > Âstatic int adt7316_i2c_write(void *client, u8 reg, u8 data)
> > Â{
> > ÂÂÂÂÂÂÂÂÂstruct i2c_client *cl = client;
> > -ÂÂÂÂÂÂÂÂint ret = 0;
> > +ÂÂÂÂÂÂÂÂint ret;
> >
> > ÂÂÂÂÂÂÂÂÂret = i2c_smbus_write_byte_data(cl, reg, data);
> > ÂÂÂÂÂÂÂÂÂif (ret < 0)
> > diff --git a/drivers/staging/lustre/lustre/ldlm/ldlm_request.c
> b/drivers/staging/lustre/lustre/ldlm/ldlm_request.c
> > index c1f8693..9c1b1be 100644
> > --- a/drivers/staging/lustre/lustre/ldlm/ldlm_request.c
> > +++ b/drivers/staging/lustre/lustre/ldlm/ldlm_request.c
> > @@ -377,7 +377,7 @@ int ldlm_cli_enqueue_fini(struct
> obd_export *exp, struct ptlrpc_request *req,
> > ÂÂÂÂÂÂÂÂÂ}
> >
> > ÂÂÂÂÂÂÂÂÂif (lvb_len > 0) {
> > -ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂint size = 0;
> > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂint size;
> >
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂsize = req_capsule_get_size(&req->rq_pill,
> &RMF_DLM_LVB,
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ Â ÂRCL_SERVER);
> > diff --git a/drivers/staging/lustre/lustre/obdclass/cl_page.c
> b/drivers/staging/lustre/lustre/obdclass/cl_page.c
> > index cd9a40c..fdaebc3 100644
> > --- a/drivers/staging/lustre/lustre/obdclass/cl_page.c
> > +++ b/drivers/staging/lustre/lustre/obdclass/cl_page.c
> > @@ -1002,7 +1002,7 @@ EXPORT_SYMBOL(cl_page_slice_add);
> > Â */
> > Âstruct cl_client_cache *cl_cache_init(unsigned long
> lru_page_max)
> > Â{
> > -ÂÂÂÂÂÂÂÂstruct cl_client_cacheÂÂÂÂÂÂÂÂ*cache = NULL;
> > +ÂÂÂÂÂÂÂÂstruct cl_client_cacheÂÂÂÂÂÂÂÂ*cache;
> >
> > ÂÂÂÂÂÂÂÂÂcache = kzalloc(sizeof(*cache), GFP_KERNEL);
> > ÂÂÂÂÂÂÂÂÂif (!cache)
> > diff --git
> a/drivers/staging/media/s5p-cec/exynos_hdmi_cecctrl.c
> b/drivers/staging/media/s5p-cec/exynos_hdmi_cecctrl.c
> > index ce95e0f..8e7e43d 100644
> > --- a/drivers/staging/media/s5p-cec/exynos_hdmi_cecctrl.c
> > +++ b/drivers/staging/media/s5p-cec/exynos_hdmi_cecctrl.c
> > @@ -171,7 +171,7 @@ void s5p_cec_set_addr(struct s5p_cec_dev
> *cec, u32 addr)
> >
> > Âu32 s5p_cec_get_status(struct s5p_cec_dev *cec)
> > Â{
> > -ÂÂÂÂÂÂÂÂu32 status = 0;
> > +ÂÂÂÂÂÂÂÂu32 status;
> >
> > ÂÂÂÂÂÂÂÂÂstatus = readb(cec->reg + S5P_CEC_STATUS_0);
> > ÂÂÂÂÂÂÂÂÂstatus |= readb(cec->reg + S5P_CEC_STATUS_1) << 8;
> > diff --git a/drivers/staging/media/s5p-cec/s5p_cec.c
> b/drivers/staging/media/s5p-cec/s5p_cec.c
> > index 2a07968..7ec3770 100644
> > --- a/drivers/staging/media/s5p-cec/s5p_cec.c
> > +++ b/drivers/staging/media/s5p-cec/s5p_cec.c
> > @@ -83,7 +83,7 @@ static int s5p_cec_adap_transmit(struct
> cec_adapter *adap, u8 attempts,
> > Âstatic irqreturn_t s5p_cec_irq_handler(int irq, void *priv)
> > Â{
> > ÂÂÂÂÂÂÂÂÂstruct s5p_cec_dev *cec = priv;
> > -ÂÂÂÂÂÂÂÂu32 status = 0;
> > +ÂÂÂÂÂÂÂÂu32 status;
> >
> > ÂÂÂÂÂÂÂÂÂstatus = s5p_cec_get_status(cec);
> >
> > diff --git a/drivers/staging/rtl8188eu/core/rtw_ap.c
> b/drivers/staging/rtl8188eu/core/rtw_ap.c
> > index 1c8fa3a..cbacbe9 100644
> > --- a/drivers/staging/rtl8188eu/core/rtw_ap.c
> > +++ b/drivers/staging/rtl8188eu/core/rtw_ap.c
> > @@ -508,7 +508,7 @@ void add_RATid(struct adapter *padapter,
> struct sta_info *psta, u8 rssi_level)
> > ÂÂÂÂÂÂÂÂÂinit_rate = get_highest_rate_idx(tx_ra_bitmap &
> 0x0fffffff) & 0x3f;
> >
> > ÂÂÂÂÂÂÂÂÂif (psta->aid < NUM_STA) {
> > -ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂu8 arg = 0;
> > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂu8 arg;
> >
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂarg = psta->mac_id & 0x1f;
> >
> > @@ -591,7 +591,7 @@ static void update_bmc_sta(struct adapter
> *padapter)
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂrtw_hal_set_odm_var(padapter,
> HAL_ODM_STA_INFO, psta, true);
> >
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ{
> > -ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂu8 arg = 0;
> > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂu8 arg;
> >
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂarg = psta->mac_id&0x1f;
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂarg |= BIT(7);
> > diff --git a/drivers/staging/rtl8188eu/core/rtw_efuse.c
> b/drivers/staging/rtl8188eu/core/rtw_efuse.c
> > index b9bdff0..98b3bd7 100644
> > --- a/drivers/staging/rtl8188eu/core/rtw_efuse.c
> > +++ b/drivers/staging/rtl8188eu/core/rtw_efuse.c
> > @@ -747,7 +747,7 @@ static bool
> hal_EfusePartialWriteCheck(struct adapter *pAdapter, u8
> efuseType, u
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ/* ÂHere to write partial
> data */
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂbadworden =
> Efuse_WordEnableDataWrite(pAdapter, startAddr+1, matched_wden,
> pTargetPkt->data);
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂif (badworden != 0x0F) {
> >
> -ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂu32ÂÂÂÂÂÂÂÂPgWriteSuccess
> = 0;
> >
> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂu32ÂÂÂÂÂÂÂÂPgWriteSuccess;
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ/* Âif write fail on
> some words, write these bad words again */
> >
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂPgWriteSuccess =
> Efuse_PgPacketWrite(pAdapter, pTargetPkt->offset, badworden,
> pTargetPkt->data);
> > diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
> b/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
> > index 2933479..118286c 100644
> > --- a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
> > +++ b/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
> > @@ -296,7 +296,7 @@ static int update_hidden_ssid(u8 *ies, u32
> ies_len, u8 hidden_ssid_mode)
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂswitch (hidden_ssid_mode) {
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂcase 1: {
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂu8 *next_ie = ssid_ie + 2 +
> ssid_len_ori;
> > -ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂu32 remain_len = 0;
> > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂu32 remain_len;
> >
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂremain_len = ies_len - (next_ie -
> ies);
> >
> > diff --git a/drivers/staging/rtl8188eu/core/rtw_recv.c
> b/drivers/staging/rtl8188eu/core/rtw_recv.c
> > index 1bc7b97..e6d4553 100644
> > --- a/drivers/staging/rtl8188eu/core/rtw_recv.c
> > +++ b/drivers/staging/rtl8188eu/core/rtw_recv.c
> > @@ -535,7 +535,7 @@ static void process_pwrbit_data(struct
> adapter *padapter,
> > ÂÂÂÂÂÂÂÂÂu8 *ptr = precv_frame->rx_data;
> > ÂÂÂÂÂÂÂÂÂstruct rx_pkt_attrib *pattrib = &precv_frame->attrib;
> > ÂÂÂÂÂÂÂÂÂstruct sta_priv *pstapriv = &padapter->stapriv;
> > -ÂÂÂÂÂÂÂÂstruct sta_info *psta = NULL;
> > +ÂÂÂÂÂÂÂÂstruct sta_info *psta;
> >
> > ÂÂÂÂÂÂÂÂÂpsta = rtw_get_stainfo(pstapriv, pattrib->src);
> >
> > @@ -560,7 +560,7 @@ static void process_wmmps_data(struct
> adapter *padapter,
> > Â#ifdef CONFIG_88EU_AP_MODE
> > ÂÂÂÂÂÂÂÂÂstruct rx_pkt_attrib *pattrib = &precv_frame->attrib;
> > ÂÂÂÂÂÂÂÂÂstruct sta_priv *pstapriv = &padapter->stapriv;
> > -ÂÂÂÂÂÂÂÂstruct sta_info *psta = NULL;
> > +ÂÂÂÂÂÂÂÂstruct sta_info *psta;
> >
> > ÂÂÂÂÂÂÂÂÂpsta = rtw_get_stainfo(pstapriv, pattrib->src);
> >
> > diff --git a/drivers/staging/rtl8188eu/core/rtw_sreset.c
> b/drivers/staging/rtl8188eu/core/rtw_sreset.c
> > index a198c57..7cda913 100644
> > --- a/drivers/staging/rtl8188eu/core/rtw_sreset.c
> > +++ b/drivers/staging/rtl8188eu/core/rtw_sreset.c
> > @@ -28,7 +28,7 @@ u8 sreset_get_wifi_status(struct adapter
> *padapter)
> > ÂÂÂÂÂÂÂÂÂstruct sreset_priv *psrtpriv =
> &padapter->HalData->srestpriv;
> >
> > ÂÂÂÂÂÂÂÂÂu8 status = WIFI_STATUS_SUCCESS;
> > -ÂÂÂÂÂÂÂÂu32 val32 = 0;
> > +ÂÂÂÂÂÂÂÂu32 val32;
> >
> > ÂÂÂÂÂÂÂÂÂval32 = usb_read32(padapter, REG_TXDMA_STATUS);
> > ÂÂÂÂÂÂÂÂÂif (val32 == 0xeaeaeaea) {
> > diff --git a/drivers/staging/rtl8188eu/core/rtw_wlan_util.c
> b/drivers/staging/rtl8188eu/core/rtw_wlan_util.c
> > index f6f1b09..a168cc0 100644
> > --- a/drivers/staging/rtl8188eu/core/rtw_wlan_util.c
> > +++ b/drivers/staging/rtl8188eu/core/rtw_wlan_util.c
> > @@ -1245,7 +1245,7 @@ unsigned int
> update_supported_rate(unsigned char *ptn, unsigned int ptn_sz)
> >
> > Âunsigned int update_MSC_rate(struct ieee80211_ht_cap
> *pHT_caps)
> > Â{
> > -ÂÂÂÂÂÂÂÂunsigned int mask = 0;
> > +ÂÂÂÂÂÂÂÂunsigned int mask;
> >
> > ÂÂÂÂÂÂÂÂÂmask = (pHT_caps->mcs.rx_mask[0] << 12) |
> > ÂÂÂÂÂÂÂÂÂ Â Â Â (pHT_caps->mcs.rx_mask[1] << 20);
> > diff --git a/drivers/staging/rtl8188eu/core/rtw_xmit.c
> b/drivers/staging/rtl8188eu/core/rtw_xmit.c
> > index 484d20a..d89bc34 100644
> > --- a/drivers/staging/rtl8188eu/core/rtw_xmit.c
> > +++ b/drivers/staging/rtl8188eu/core/rtw_xmit.c
> > @@ -928,7 +928,7 @@ s32 rtw_txframes_sta_ac_pending(struct
> adapter *padapter, struct pkt_attrib *pat
> > Â */
> > Âu32 rtw_calculate_wlan_pkt_size_by_attribue(struct pkt_attrib
> *pattrib)
> > Â{
> > -ÂÂÂÂÂÂÂÂu32ÂÂÂÂÂÂÂÂlen = 0;
> > +ÂÂÂÂÂÂÂÂu32ÂÂÂÂÂÂÂÂlen;
> >
> > ÂÂÂÂÂÂÂÂÂlen = pattrib->hdrlen + pattrib->iv_len; /* ÂWLAN
> Header and IV */
> > ÂÂÂÂÂÂÂÂÂlen += SNAP_SIZE + sizeof(u16); /* ÂLLC */
> > diff --git a/drivers/staging/rtl8188eu/hal/hal_intf.c
> b/drivers/staging/rtl8188eu/hal/hal_intf.c
> > index a11c7b4..e723fb5 100644
> > --- a/drivers/staging/rtl8188eu/hal/hal_intf.c
> > +++ b/drivers/staging/rtl8188eu/hal/hal_intf.c
> > @@ -44,7 +44,7 @@ uintÂÂÂÂÂÂÂÂ rtw_hal_init(struct adapter
> *adapt)
> >
> > Âuint rtw_hal_deinit(struct adapter *adapt)
> > Â{
> > -ÂÂÂÂÂÂÂÂuintÂÂÂÂÂÂÂÂstatus = _SUCCESS;
> > +ÂÂÂÂÂÂÂÂuintÂÂÂÂÂÂÂÂstatus;
> >
> > ÂÂÂÂÂÂÂÂÂstatus = rtl8188eu_hal_deinit(adapt);
> >
> > diff --git a/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c
> b/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c
> > index 763eccd..e7fe8aa 100644
> > --- a/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c
> > +++ b/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c
> > @@ -1496,7 +1496,7 @@ static int rtw_wx_get_rate(struct
> net_device *dev,
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ Â Â struct iw_request_info *info,
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ Â Â union iwreq_data *wrqu, char
> *extra)
> > Â{
> > -ÂÂÂÂÂÂÂÂu16 max_rate = 0;
> > +ÂÂÂÂÂÂÂÂu16 max_rate;
> >
> > ÂÂÂÂÂÂÂÂÂmax_rate = rtw_get_cur_max_rate((struct adapter
> *)rtw_netdev_priv(dev));
> >
> > diff --git a/drivers/staging/rtl8188eu/os_dep/xmit_linux.c
> b/drivers/staging/rtl8188eu/os_dep/xmit_linux.c
> > index e097c61..2e06cdb 100644
> > --- a/drivers/staging/rtl8188eu/os_dep/xmit_linux.c
> > +++ b/drivers/staging/rtl8188eu/os_dep/xmit_linux.c
> > @@ -43,7 +43,7 @@ void _rtw_open_pktfile(struct sk_buff
> *pktptr, struct pkt_file *pfile)
> >
> > Âuint _rtw_pktfile_read(struct pkt_file *pfile, u8 *rmem, uint
> rlen)
> > Â{
> > -ÂÂÂÂÂÂÂÂuintÂÂÂÂÂÂÂÂlen = 0;
> > +ÂÂÂÂÂÂÂÂuintÂÂÂÂÂÂÂÂlen;
> >
> >
> > ÂÂÂÂÂÂÂÂÂlen = Ârtw_remainder_len(pfile);
> > diff --git a/drivers/staging/rtl8712/rtl8712_xmit.c
> b/drivers/staging/rtl8712/rtl8712_xmit.c
> > index c4f03a6..7167d76 100644
> > --- a/drivers/staging/rtl8712/rtl8712_xmit.c
> > +++ b/drivers/staging/rtl8712/rtl8712_xmit.c
> > @@ -750,7 +750,7 @@ static void dump_xframe(struct _adapter
> *padapter,
> >
> > Âint r8712_xmit_direct(struct _adapter *padapter, struct
> xmit_frame *pxmitframe)
> > Â{
> > -ÂÂÂÂÂÂÂÂint res = _SUCCESS;
> > +ÂÂÂÂÂÂÂÂint res;
> >
> > ÂÂÂÂÂÂÂÂÂres = r8712_xmitframe_coalesce(padapter,
> pxmitframe->pkt, pxmitframe);
> > ÂÂÂÂÂÂÂÂÂpxmitframe->pkt = NULL;
> > diff --git a/drivers/staging/rtl8712/rtl871x_mp.c
> b/drivers/staging/rtl8712/rtl871x_mp.c
> > index 3c10a2c..ccc4358 100644
> > --- a/drivers/staging/rtl8712/rtl871x_mp.c
> > +++ b/drivers/staging/rtl8712/rtl871x_mp.c
> > @@ -295,7 +295,7 @@ void r8712_SetChannel(struct _adapter
> *pAdapter)
> >
> > Âstatic void SetCCKTxPower(struct _adapter *pAdapter, u8
> TxPower)
> > Â{
> > -ÂÂÂÂÂÂÂÂu16 TxAGC = 0;
> > +ÂÂÂÂÂÂÂÂu16 TxAGC;
> >
> > ÂÂÂÂÂÂÂÂÂTxAGC = TxPower;
> > ÂÂÂÂÂÂÂÂÂset_bb_reg(pAdapter, rTxAGC_CCK_Mcs32, bTxAGCRateCCK,
> TxAGC);
> > @@ -722,7 +722,7 @@ static u32 GetPhyRxPktCounts(struct
> _adapter *pAdapter, u32 selbit)
> >
> > Âu32 r8712_GetPhyRxPktReceived(struct _adapter *pAdapter)
> > Â{
> > -ÂÂÂÂÂÂÂÂu32 OFDM_cnt = 0, CCK_cnt = 0, HT_cnt = 0;
> > +ÂÂÂÂÂÂÂÂu32 OFDM_cnt, CCK_cnt = 0, HT_cnt = 0;
> >
> > ÂÂÂÂÂÂÂÂÂOFDM_cnt = GetPhyRxPktCounts(pAdapter,
> OFDM_MPDU_OK_BIT);
> > ÂÂÂÂÂÂÂÂÂCCK_cnt = GetPhyRxPktCounts(pAdapter,
> CCK_MPDU_OK_BIT);
> > @@ -732,7 +732,7 @@ u32 r8712_GetPhyRxPktReceived(struct
> _adapter *pAdapter)
> >
> > Âu32 r8712_GetPhyRxPktCRC32Error(struct _adapter *pAdapter)
> > Â{
> > -ÂÂÂÂÂÂÂÂu32 OFDM_cnt = 0, CCK_cnt = 0, HT_cnt = 0;
> > +ÂÂÂÂÂÂÂÂu32 OFDM_cnt, CCK_cnt = 0, HT_cnt = 0;
> >
> > ÂÂÂÂÂÂÂÂÂOFDM_cnt = GetPhyRxPktCounts(pAdapter,
> OFDM_MPDU_FAIL_BIT);
> > ÂÂÂÂÂÂÂÂÂCCK_cnt = GetPhyRxPktCounts(pAdapter,
> CCK_MPDU_FAIL_BIT);
> > diff --git a/drivers/staging/rts5208/rtsx_chip.c
> b/drivers/staging/rts5208/rtsx_chip.c
> > index 3511157..5ec9d34 100644
> > --- a/drivers/staging/rts5208/rtsx_chip.c
> > +++ b/drivers/staging/rts5208/rtsx_chip.c
> > @@ -2086,7 +2086,7 @@ int rtsx_pre_handle_interrupt(struct
> rtsx_chip *chip)
> > ÂÂÂÂÂÂÂÂÂu32 status, int_enable;
> > ÂÂÂÂÂÂÂÂÂbool exit_ss = false;
> > Â#ifdef SUPPORT_OCP
> > -ÂÂÂÂÂÂÂÂu32 ocp_int = 0;
> > +ÂÂÂÂÂÂÂÂu32 ocp_int;
> >
> > ÂÂÂÂÂÂÂÂÂocp_int = OC_INT;
> > Â#endif
> > diff --git a/drivers/staging/rts5208/sd.c
> b/drivers/staging/rts5208/sd.c
> > index bdd35b6..53db0cb 100644
> > --- a/drivers/staging/rts5208/sd.c
> > +++ b/drivers/staging/rts5208/sd.c
> > @@ -514,7 +514,7 @@ static int sd_check_csd(struct rtsx_chip
> *chip, char check_wp)
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ(1 << (c_size_mult +
> 2)))
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ<< (blk_size - 9);
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ} else {
> > -ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂu32 total_sector = 0;
> > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂu32 total_sector;
> >
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂtotal_sector = (((u32)rsp[8] & 0x3f)
> << 16) |
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ((u32)rsp[9] << 8) |
> (u32)rsp[10];
> > @@ -617,7 +617,7 @@ static void sd_choose_proper_clock(struct
> rtsx_chip *chip)
> > Âstatic int sd_set_clock_divider(struct rtsx_chip *chip, u8
> clk_div)
> > Â{
> > ÂÂÂÂÂÂÂÂÂint retval;
> > -ÂÂÂÂÂÂÂÂu8 mask = 0, val = 0;
> > +ÂÂÂÂÂÂÂÂu8 mask, val = 0;
> >
> > ÂÂÂÂÂÂÂÂÂmask = 0x60;
> > ÂÂÂÂÂÂÂÂÂif (clk_div == SD_CLK_DIVIDE_0)
> > diff --git a/drivers/staging/sm750fb/ddk750_chip.c
> b/drivers/staging/sm750fb/ddk750_chip.c
> > index 9aaf1fd..b2fbcfac 100644
> > --- a/drivers/staging/sm750fb/ddk750_chip.c
> > +++ b/drivers/staging/sm750fb/ddk750_chip.c
> > @@ -389,7 +389,7 @@ unsigned int sm750_format_pll_reg(struct
> pll_value *pPLL)
> > ÂÂÂÂÂÂÂÂÂunsigned int OD = pPLL->OD;
> > ÂÂÂÂÂÂÂÂÂunsigned int M = pPLL->M;
> > ÂÂÂÂÂÂÂÂÂunsigned int N = pPLL->N;
> > -ÂÂÂÂÂÂÂÂunsigned int reg = 0;
> > +ÂÂÂÂÂÂÂÂunsigned int reg;
> >
> > ÂÂÂÂÂÂÂÂÂ/*
> > ÂÂÂÂÂÂÂÂÂ * Note that all PLL's have the same format. Here, we
> just use
> > diff --git a/drivers/staging/sm750fb/ddk750_power.c
> b/drivers/staging/sm750fb/ddk750_power.c
> > index 6167e30..baf80c0 100644
> > --- a/drivers/staging/sm750fb/ddk750_power.c
> > +++ b/drivers/staging/sm750fb/ddk750_power.c
> > @@ -31,7 +31,7 @@ static unsigned int get_power_mode(void)
> > Â */
> > Âvoid sm750_set_power_mode(unsigned int mode)
> > Â{
> > -ÂÂÂÂÂÂÂÂunsigned int ctrl = 0;
> > +ÂÂÂÂÂÂÂÂunsigned int ctrl;
> >
> > ÂÂÂÂÂÂÂÂÂctrl = PEEK32(POWER_MODE_CTRL) &
> ~POWER_MODE_CTRL_MODE_MASK;
> >
> > diff --git a/drivers/staging/speakup/speakup_ltlk.c
> b/drivers/staging/speakup/speakup_ltlk.c
> > index b474e8b..4f7fb35 100644
> > --- a/drivers/staging/speakup/speakup_ltlk.c
> > +++ b/drivers/staging/speakup/speakup_ltlk.c
> > @@ -156,7 +156,7 @@ static void synth_interrogate(struct
> spk_synth *synth)
> >
> > Âstatic int synth_probe(struct spk_synth *synth)
> > Â{
> > -ÂÂÂÂÂÂÂÂint failed = 0;
> > +ÂÂÂÂÂÂÂÂint failed;
> >
> > ÂÂÂÂÂÂÂÂÂfailed = spk_serial_synth_probe(synth);
> > ÂÂÂÂÂÂÂÂÂif (failed == 0)
> > diff --git a/drivers/staging/unisys/visorbus/visorchipset.c
> b/drivers/staging/unisys/visorbus/visorchipset.c
> > index 336af52..576e7a9 100644
> > --- a/drivers/staging/unisys/visorbus/visorchipset.c
> > +++ b/drivers/staging/unisys/visorbus/visorchipset.c
> > @@ -350,7 +350,7 @@ static DEVICE_ATTR_RW(remaining_steps);
> > Âstatic uuid_le
> > Âparser_id_get(struct parser_context *ctx)
> > Â{
> > -ÂÂÂÂÂÂÂÂstruct spar_controlvm_parameters_header *phdr = NULL;
> > +ÂÂÂÂÂÂÂÂstruct spar_controlvm_parameters_header *phdr;
> >
> > ÂÂÂÂÂÂÂÂÂphdr = (struct spar_controlvm_parameters_header
> *)(ctx->data);
> > ÂÂÂÂÂÂÂÂÂreturn phdr->id;
> > @@ -396,7 +396,7 @@ parser_string_get(struct parser_context
> *ctx)
> > Âstatic void *
> > Âparser_name_get(struct parser_context *ctx)
> > Â{
> > -ÂÂÂÂÂÂÂÂstruct spar_controlvm_parameters_header *phdr = NULL;
> > +ÂÂÂÂÂÂÂÂstruct spar_controlvm_parameters_header *phdr;
> >
> > ÂÂÂÂÂÂÂÂÂphdr = (struct spar_controlvm_parameters_header
> *)(ctx->data);
> > ÂÂÂÂÂÂÂÂÂctx->curr = ctx->data + phdr->name_offset;
> > diff --git a/drivers/staging/wlan-ng/cfg80211.c
> b/drivers/staging/wlan-ng/cfg80211.c
> > index aa0e5a3..b24d9bf 100644
> > --- a/drivers/staging/wlan-ng/cfg80211.c
> > +++ b/drivers/staging/wlan-ng/cfg80211.c
> > @@ -244,7 +244,7 @@ static int prism2_set_default_key(struct
> wiphy *wiphy, struct net_device *dev,
> > ÂÂÂÂÂÂÂÂÂstruct wlandevice *wlandev = dev->ml_priv;
> >
> > ÂÂÂÂÂÂÂÂÂint err = 0;
> > -ÂÂÂÂÂÂÂÂint result = 0;
> > +ÂÂÂÂÂÂÂÂint result;
> >
> > ÂÂÂÂÂÂÂÂÂresult = prism2_domibset_uint32(wlandev,
> >
> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂDIDmib_dot11smt_dot11PrivacyTable_dot11WEPDefaultKeyID,
> > diff --git a/drivers/staging/xgifb/XGI_main_26.c
> b/drivers/staging/xgifb/XGI_main_26.c
> > index 777cd6e..c6d2941 100644
> > --- a/drivers/staging/xgifb/XGI_main_26.c
> > +++ b/drivers/staging/xgifb/XGI_main_26.c
> > @@ -640,7 +640,7 @@ static void XGIfb_bpp_to_var(struct
> xgifb_video_info *xgifb_info,
> >
> > Âstatic void XGIfb_pre_setmode(struct xgifb_video_info
> *xgifb_info)
> > Â{
> > -ÂÂÂÂÂÂÂÂu8 cr30 = 0, cr31 = 0;
> > +ÂÂÂÂÂÂÂÂu8 cr30 = 0, cr31;
> >
> > ÂÂÂÂÂÂÂÂÂcr31 = xgifb_reg_get(XGICR, 0x31);
> > ÂÂÂÂÂÂÂÂÂcr31 &= ~0x60;
> > --
> > 2.7.4
> >
> > --
> > You received this message because you are subscribed to the
> Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from
> it, send an email to outreachy-kern...@xxxxxxxxxxxxxxxxx
> > To post to this group, send email to
> outreach...@xxxxxxxxxxxxxxxxx
> > To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/20170221170356.GA12793%4
> 0singhal-Inspiron-5558.
> > For more options, visit https://groups.google.com/d/optout.
> >
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@xxxxxxxxxxxxxxxxx
> To post to this group, send email to outreachy-kernel@xxxxxxxxxxxxxxxxx
> To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/b2c93b5d-3df1-4b04-b636-
> 1235af0a7006%40googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
>

Next message: Luis R. Rodriguez: "Re: [PATCH 1/2] firmware: add more flexible request_firmware_async function"
Previous message: Jonathan Dieter: "[PATCH v2 2/2] usbip: Fix implicit fallthrough warning"
In reply to: Julia Lawall: "Re: [Outreachy kernel] [PATCH 4/6] staging: Drop useless initialisation"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]