Re: [PATCH v17 0/3] USB Type-C Connector class

[Felipe Balbi]

Hi,

Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx> writes:
> The USB Type-C class is meant to provide unified interface to the
> userspace to present the USB Type-C ports in a system.
>
> Changes since v16:
> - Using PTR_ERR_OR_ZERO macro in typec_init().
>
> Changes since v15:
> - "stingification" as proposed by Felipe
> - Checking ARRAY_SIZE in supported_accessory_modes() as proposed by Guenter
>
> Changes since v14:
> - Fixes proposed by Mika
> - "identity" directory for all discover identity VDOs instead of "vdo" attribute
> - alternate mode device names to just "svid-<svid>"
>
> Changes since v13:
> - New API. Everything is registered separately.
>
> Changes since v12:
> - Added prefer_role member to typec_capability structure as requested by Guenter
>
> Changes since v11:
> - The port drivers are responsible of removing the alternate
>   modes (just like the documentation already said).
>
> Changes since v10:
> - Using ATTRIBUTE_GROUPS and DEVICE_ATTR marcos everywhere
> - Moved sysfs_match_string to lib/string.c
> - Rationalized uevents
> - Calling ida_destroy
>
> Changes since v9:
> - Minor typec_wcove.c cleanup as proposed by Guenter Roeck. No
>   function affect.
>
> Changes since v8:
> - checking sysfs_streq() result correctly in sysfs_strmatch
> - fixed accessory check in supported_accessory_mode
> - using "none" as the only string that can clear the preferred role
>
> Changes since v7:
> - Removed "type" attribute from partners
> - Added supports_usb_power_delivery attribute for partner and cable
>
> Changes since v6:
> - current_vconn_role attr renamed to vconn_source (no API changes)
> - Small documentation improvements proposed by Vincent Palatin
>
> Changes since v5:
> - Only updating the roles based on driver notifications
> - Added MODULE_ALIAS for the WhiskeyCove module
> - Including the patch that creates the actual platform device for the
>   WhiskeyCove Type-C PHY in this series.
>
> Changes since v4:
> - Remove the port lock completely
>
> Changes since v3:
> - Documentation cleanup as proposed by Roger Quadros
> - Setting partner altmodes member to NULL on removal and fixing a
>   warning, as proposed by Guenter Roeck
> - Added the following attributes for partners and cables:
>   * supports_usb_power_delivery
>   * id_header_vdo
> - "id_header_vdo" is visible only when the partner or cable supports
>   USB Power Delivery communication.
> - Partner attribute "accessory" is hidden when the partner type is not
>   "Accessory".
>
> Changes since v2:
> - Notification on role and alternate mode changes
> - cleanups
>
> Changes since v1:
> - Completely rewrote alternate mode support
> - Patners, cables and cable plugs presented as devices.
>
>
> Heikki Krogerus (3):
>   lib/string: add sysfs_match_string helper
>   usb: USB Type-C connector class
>   usb: typec: add driver for Intel Whiskey Cove PMIC USB Type-C PHY

Just to clarify one thing here: wherever it says "Reviewed-by: Felipe
Balbi..." you could also read "Reviewed-and-Tested-by: Felipe Balbi..."
as I have been running these patches for past few months to test code on
Intel Joule.

-- 
balbi