Re: [PATCH] platform: intel_turbo_max_3: make it explicitly non-modular

[Srinivas Pandruvada]

On Thu, 2017-02-16 at 19:37 -0800, Darren Hart wrote:
> On Mon, Feb 13, 2017 at 07:37:00PM -0500, Paul Gortmaker wrote:
> > The Kconfig currently controlling compilation of this code is:
> > 
> > drivers/platform/x86/Kconfig:config INTEL_TURBO_MAX_3
> > drivers/platform/x86/Kconfig:ÂÂÂbool "Intel Turbo Boost Max
> > Technology 3.0 enumeration driver"
> > 
> > ...meaning that it currently is not being built as a module by
> > anyone.
> > 
> > Lets remove the couple traces of modular infrastructure use, so
> > that
> > when reading the driver there is no doubt it is builtin-only.
> > 
> > Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.
> > 
> > We also delete the MODULE_LICENSE tag etc. since all that
> > information
> > was (or is now) contained at the top of the file in the comments.
> > 
> > We do uncover some implicit includes during build coverage that
> > were hidden behind the module.h which pulls in a lot of dependants.
> > 
> 
> Paul, this all looks so very familiar... have we been through this
> before? Maybe
> for another driver...
> 
> > Cc: Darren Hart <dvhart@xxxxxxxxxxxxx>
> > Cc: Andy Shevchenko <andy@xxxxxxxxxxxxx>
> > Cc: Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx>
> 
> Srinivas, any objections?
This module can be loadable just by adding EXPORT_GPL to two scheduler
function. I was hoping that someone will require those functions to be
exported.
But any way I have no objections in this case as this driver doesn't
have to be loadable at all.

Thanks,
Srinivas


> 
> > Cc: platform-driver-x86@xxxxxxxxxxxxxxx
> > Signed-off-by: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx>
> > ---
> > Âdrivers/platform/x86/intel_turbo_max_3.c | 11 +++++------
> > Â1 file changed, 5 insertions(+), 6 deletions(-)
> > 
> > diff --git a/drivers/platform/x86/intel_turbo_max_3.c
> > b/drivers/platform/x86/intel_turbo_max_3.c
> > index 0103f5b32e34..4f60d8e32a0a 100644
> > --- a/drivers/platform/x86/intel_turbo_max_3.c
> > +++ b/drivers/platform/x86/intel_turbo_max_3.c
> > @@ -3,6 +3,8 @@
> > Â * Copyright (c) 2017, Intel Corporation.
> > Â * All rights reserved.
> > Â *
> > + * Author: Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxx
> > m>
> > + *
> > Â * This program is free software; you can redistribute it and/or
> > modify it
> > Â * under the terms and conditions of the GNU General Public
> > License,
> > Â * version 2, as published by the Free Software Foundation.
> > @@ -16,7 +18,9 @@
> > Â#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> > Â
> > Â#include <linux/kernel.h>
> > -#include <linux/module.h>
> > +#include <linux/init.h>
> > +#include <linux/topology.h>
> > +#include <linux/workqueue.h>
> > Â#include <linux/cpuhotplug.h>
> > Â#include <linux/cpufeature.h>
> > Â#include <asm/cpu_device_id.h>
> > @@ -123,7 +127,6 @@ static const struct x86_cpu_id
> > itmt_legacy_cpu_ids[] = {
> > Â	ICPU(INTEL_FAM6_BROADWELL_X),
> > Â	{}
> > Â};
> > -MODULE_DEVICE_TABLE(x86cpu, itmt_legacy_cpu_ids);
> > Â
> > Âstatic int __init itmt_legacy_init(void)
> > Â{
> > @@ -146,7 +149,3 @@ static int __init itmt_legacy_init(void)
> > Â	return 0;
> > Â}
> > Âlate_initcall(itmt_legacy_init)
> > -
> > -MODULE_DESCRIPTION("Intel Turbo Boost Max 3.0 enumeration
> > driver");
> > -MODULE_AUTHOR("Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxx
> > l.com>");
> > -MODULE_LICENSE("GPL v2");
> > --Â
> > 2.11.0
> > 
> > 
> 
>