Re: [PATCH] ipmi: bt-bmc: Use a regmap for register access

From: Andrew Jeffery
Date: Mon Feb 20 2017 - 09:54:49 EST


On Mon, 2017-02-20 at 07:35 -0600, Corey Minyard wrote:
> On 02/19/2017 10:45 PM, Andrew Jeffery wrote:
> > Hi Cory,
> >
> > On Tue, 2016-12-06 at 16:02 +0100, CÃdric Le Goater wrote:
> > > [ this is a resend bc of some mailing list issues]
> > >
> > > On 12/06/2016 03:57 AM, Andrew Jeffery wrote:
> > > > The registers for the bt-bmc device live under the Aspeed LPC
> > > > controller. Devicetree bindings have recently been introduced for the
> > > > LPC controller where the "host" portion of the LPC register space is
> > > > described as a syscon device. Future devicetrees describing the bt-bmc
> > > > device should nest its node under the appropriate "simple-mfd", "syscon"
> > > > compatible node.
> > > >
> > > > This change allows the bt-bmc driver to function with both syscon and
> > > > non-syscon- based devicetree descriptions by always using a regmap for
> > > > register access, either retrieved from the parent syscon device or
> > > > instantiated if none exists.
> > > >
> > > > The patch has been tested on an OpenPOWER Palmetto machine, successfully
> > > > booting, rebooting and powering down the host.
> > > >
> > > > Signed-off-by: Andrew Jeffery <andrew@xxxxxxxx>
> > >
> > > It would be nice to have an example of the associated binding.
> > > I did not see it. A part from that :
> > >
> > > Reviewed-by: CÃdric Le Goater <clg@xxxxxxxx>
> >
> > Will this make it into 4.11?
>
> I thought you were doing a v2 with a few little fixes.ÂÂGet it to meÂ
> quickly, if you can.

Reading back it was a bit ambiguous. No worries, I'll roll in the small
fixes and send a v2.

Cheers,

Andrew

Attachment: signature.asc
Description: This is a digitally signed message part