Re: [Outreachy kernel] [PATCH 3/6] staging: rtl8192e: Fix block comments warning

From: Julia Lawall
Date: Sat Feb 18 2017 - 10:31:02 EST




On Sat, 18 Feb 2017, simran singhal wrote:

> Align * on a line, to conform to the kernal coding
> style for block comments.

It is not clear what is means to align * on a line. What line?

What has been done is to add a space at the beginning of the line. But
then the line goes over 80 characters and doesn't line up any more on the
right side. I would guess that you should have gotten a new warning by
having gone over 80 characters. Fixing one warning should not introduce a
new one, especially for something purely decorative, like this.

julia

>
> Signed-off-by: simran singhal <singhalsimran0@xxxxxxxxx>
> ---
> drivers/staging/rtl8192e/rtl819x_HT.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8192e/rtl819x_HT.h b/drivers/staging/rtl8192e/rtl819x_HT.h
> index 6eb018f..48d101a 100644
> --- a/drivers/staging/rtl8192e/rtl819x_HT.h
> +++ b/drivers/staging/rtl8192e/rtl819x_HT.h
> @@ -11,7 +11,7 @@
> *
> * Contact Information:
> * wlanfae <wlanfae@xxxxxxxxxxx>
> -******************************************************************************/
> + ******************************************************************************/
> #ifndef _RTL819XU_HTTYPE_H_
> #define _RTL819XU_HTTYPE_H_
>
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@xxxxxxxxxxxxxxxxx
> To post to this group, send email to outreachy-kernel@xxxxxxxxxxxxxxxxx
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170218152351.GA28908%40singhal-Inspiron-5558.
> For more options, visit https://groups.google.com/d/optout.
>