Re: [PATCH v2 1/9] staging: rtl8192u: fixing white space issue

From: Greg KH
Date: Thu Feb 16 2017 - 13:34:50 EST


On Wed, Feb 15, 2017 at 01:37:13AM +0530, simran singhal wrote:
> Fix the following checkpatch.pl error and warnings:
> WARNING: please, no space before tabs
>
> Signed-off-by: simran singhal <singhalsimran0@xxxxxxxxx>
> ---
> drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h b/drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h
> index 873969c..a54dfad 100644
> --- a/drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h
> +++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h
> @@ -30,7 +30,7 @@ typedef struct _TX_TS_RECORD{
> u16 TxCurSeq;
> BA_RECORD TxPendingBARecord; /* For BA Originator */
> BA_RECORD TxAdmittedBARecord; /* For BA Originator */
> -/* QOS_DL_RECORD DLRecord; */
> +/* QOS_DL_RECORD DLRecord; */

Why did you change the number of tabs here?

Also, just delete unused fields, why keep them around?

thanks,

greg k-h