Re: [PATCH] cdrom: Make device operations read-only

From: David Miller
Date: Mon Feb 13 2017 - 21:58:22 EST


From: Kees Cook <keescook@xxxxxxxxxxxx>
Date: Mon, 13 Feb 2017 16:25:26 -0800

> diff --git a/drivers/ide/ide-cd.c b/drivers/ide/ide-cd.c
> index 9cbd217bc0c9..ab9232e1e16f 100644
> --- a/drivers/ide/ide-cd.c
> +++ b/drivers/ide/ide-cd.c
> @@ -1166,7 +1166,7 @@ void ide_cdrom_update_speed(ide_drive_t *drive, u8 *buf)
> CDC_CD_RW | CDC_DVD | CDC_DVD_R | CDC_DVD_RAM | CDC_GENERIC_PACKET | \
> CDC_MO_DRIVE | CDC_MRW | CDC_MRW_W | CDC_RAM)
>
> -static struct cdrom_device_ops ide_cdrom_dops = {
> +static const struct cdrom_device_ops ide_cdrom_dops = {
> .open = ide_cdrom_open_real,
> .release = ide_cdrom_release_real,
> .drive_status = ide_cdrom_drive_status,

Acked-by: David S. Miller <davem@xxxxxxxxxxxxx>