Re: [PATCH] staging: comedi: Fix incorrect type assignment

[Ian Abbott]

On 08/02/17 13:26, Karthik Nayak wrote:
> Hello,
>
> On Wed, Feb 8, 2017 at 6:43 PM, Ian Abbott <abbotti@xxxxxxxxx> wrote:
> > On 07/02/17 19:06, Karthik Nayak wrote:
> > > This patch fixes the following sparse error:
> > > drivers/staging/comedi/drivers//ni_pcimio.c:1229:32: warning: incorrect
> > > type in assignment (different base types)
> > > drivers/staging/comedi/drivers//ni_pcimio.c:1229:32:    expected
> > > restricted __be32 [usertype] serial_number
> > > drivers/staging/comedi/drivers//ni_pcimio.c:1229:32:    got unsigned int
> > >
> > > This is done by introducing a temporary variable which is of type
> > > '__be32' and converting the existing variable to type 'unsigned int'.
> > >
> > > Signed-off-by: Karthik Nayak <Karthik.188@xxxxxxxxx>
> > > ---
> > >  drivers/staging/comedi/drivers/ni_pcimio.c | 5 +++--
> > >  drivers/staging/comedi/drivers/ni_stc.h    | 2 +-
> > >  2 files changed, 4 insertions(+), 3 deletions(-)
[snip]

> > (On a side note, nothing actually uses serial number, so the code that reads
> > it from the EEPROM could just be ripped out.)
> >
> > Reviewed-by: Ian Abbott <abbotti@xxxxxxxxx>
>
> Yea, I saw that, was assuming there might be a purposed use case scenario.

AFAICT it's never been used - not even to print a kernel log message or 
anything.

> Do you want me to send another patch?

If you want.  If you plan to do so, could you indicate whether you are 
going to base the patch on top of this one, or whether this patch should 
be discarded.  Thanks!

--
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@xxxxxxxxx> )=-
-=(                          Web: http://www.mev.co.uk/  )=-