Re: [PATCH] mfd: rtsx: Convert forgotten dev_info() statement to pcr_dbg()

From: Lee Jones
Date: Wed Feb 08 2017 - 07:02:31 EST


On Thu, 02 Feb 2017, Borislav Petkov wrote:

> From: Borislav Petkov <bp@xxxxxxx>
>
> It is a debugging statement so make it be issued only then.
>
> No functionality change.
>
> Signed-off-by: Borislav Petkov <bp@xxxxxxx>
> Cc: Lee Jones <lee.jones@xxxxxxxxxx>
> ---
> drivers/mfd/rtsx_pcr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/rtsx_pcr.c b/drivers/mfd/rtsx_pcr.c
> index 98029ee0959e..850590aac008 100644
> --- a/drivers/mfd/rtsx_pcr.c
> +++ b/drivers/mfd/rtsx_pcr.c
> @@ -927,7 +927,7 @@ static irqreturn_t rtsx_pci_isr(int irq, void *dev_id)
>
> static int rtsx_pci_acquire_irq(struct rtsx_pcr *pcr)
> {
> - dev_info(&(pcr->pci->dev), "%s: pcr->msi_en = %d, pci->irq = %d\n",
> + pcr_dbg(pcr, "%s: pcr->msi_en = %d, pci->irq = %d\n",
> __func__, pcr->msi_en, pcr->pci->irq);

I usually disapprove of these kinds of abstractions.

What is the point of it?

Why can't you just use dev_dbg()?

> if (request_irq(pcr->pci->irq, rtsx_pci_isr,

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog