[PATCH 2/2] spi: s3c64xx: fix potential division by zero

From: Andi Shyti
Date: Tue Feb 07 2017 - 03:11:04 EST


Even though it's quite unlikely to happen in this particular
case, clk_get_rate can return '0' if sdd->src_clk is not set
properly. In that case we would have a clear division by '0'.

Check the return value of clk_get_rate and fail in case it
returns '0'.

This patch fixes '1397922 Division or modulo by zero' from
scan.coverity.com

Signed-off-by: Andi Shyti <andi.shyti@xxxxxxxxxxx>
---
drivers/spi/spi-s3c64xx.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
index f6ea9ae047ec..a2ec07f44e33 100644
--- a/drivers/spi/spi-s3c64xx.c
+++ b/drivers/spi/spi-s3c64xx.c
@@ -811,6 +811,8 @@ static int s3c64xx_spi_setup(struct spi_device *spi)

/* Max possible */
speed = clk_get_rate(sdd->src_clk) / 2 / (0 + 1);
+ if (!speed)
+ goto setup_exit;

if (spi->max_speed_hz > speed)
spi->max_speed_hz = speed;
--
2.11.0