Re: [PATCH 4/9] ARM: sun5i: Add UART2 pin group

From: Maxime Ripard
Date: Mon Feb 06 2017 - 15:17:35 EST


Hi,

On Mon, Feb 06, 2017 at 03:17:40PM +0800, Chen-Yu Tsai wrote:
> On Mon, Feb 6, 2017 at 2:49 AM, Maxime Ripard
> <maxime.ripard@xxxxxxxxxxxxxxxxxx> wrote:
> > There's one UART2 pin group that can be used across all sun5i SoCs.
> > However, the A10s already has one pin group for that controller.
> >
> > Change the index of the one in the A10s DTSI, and add the common one to
> > sun5i.dtsi
>
> Kind of goes against the tradition of not adding stuff no one uses?
> Perhaps add a comment instead? I'm OK either way though.

Not really, this is used by the CHIP Pro.

Maxime

--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Attachment: signature.asc
Description: PGP signature