Re: [PATCH -next] drm: mxsfb: Make local symbol mxsfb_funcs static

From: Daniel Vetter
Date: Mon Feb 06 2017 - 05:02:38 EST


On Sun, Feb 05, 2017 at 04:05:38PM +0000, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@xxxxxxxxxx>
>
> Fixes the following sparse warning:
>
> drivers/gpu/drm/mxsfb/mxsfb_drv.c:129:38: warning:
> symbol 'mxsfb_funcs' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <weiyongjun1@xxxxxxxxxx>

Both of your patches applied to drm-misc-next for 4.12.

Thanks, Daniel

> ---
> drivers/gpu/drm/mxsfb/mxsfb_drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
> index cdfbe02..ff0495d 100644
> --- a/drivers/gpu/drm/mxsfb/mxsfb_drv.c
> +++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
> @@ -126,7 +126,7 @@ static int mxsfb_pipe_prepare_fb(struct drm_simple_display_pipe *pipe,
> return drm_fb_cma_prepare_fb(&pipe->plane, plane_state);
> }
>
> -struct drm_simple_display_pipe_funcs mxsfb_funcs = {
> +static struct drm_simple_display_pipe_funcs mxsfb_funcs = {
> .enable = mxsfb_pipe_enable,
> .disable = mxsfb_pipe_disable,
> .update = mxsfb_pipe_update,
>
>
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch