Re: [PATCH v2 05/15] HID: logitech-hidpp: forward device info in power_supply

From: Bastien Nocera
Date: Fri Feb 03 2017 - 10:08:31 EST


On Thu, 2017-02-02 at 15:12 +0100, Benjamin Tissoires wrote:
> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂcase POWER_SUPPLY_PROP_MANUFACTURER:
> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂval->strval = "Logitech, Inc.";

I don't like this change. I'd prefer the concatenated manufacturer and
model strings leading to user-friendly strings, and "Logitech T650" is
better than "Logitech, Inc. T650".