Re: [PATCH 1/4] selftests, x86, protection_keys: fix unused variable compile warnings

From: Ingo Molnar
Date: Fri Feb 03 2017 - 01:43:48 EST



* Shuah Khan <shuahkh@xxxxxxxxxxxxxxx> wrote:

> On 02/02/2017 04:45 PM, Dave Hansen wrote:
> > On 02/02/2017 03:36 PM, Shuah Khan wrote:
> >> This patches is already in linux-kselftest next for 4.11
> >>
> >> Is there a reason why you chose to resend these.
> >
> > Oh, my apologies! I didn't realize it had been picked up elsewhere.
> > Ingo had mentioned a few times in the last few days that he'd noticed
> > the warnings.
> >
> > So, x86 maintainers, do we want these to go through the kselftest tree
> > or the x86 tree?
> >
>
> I usually let many of the new tests that depend on new features go through
> x86 tree. Patches that fix problems that are already in kselftest, I send
> them up in via kselftest.
>
> I noticed these when very early on when 4.10-rc1 came out and send the patches
> out. SO they have been in linux-kselftest next for a while now.

That's OK, but please Cc: me (or at least lkml) next time around.

Also, these should have been sent to Linus as fixes once the warnings were
noticed, not queued up for v4.11 - but it's probably too late for that.

Are you going to pick up the other two fixes as well? They look good to me:

Acked-by: Ingo Molnar <mingo@xxxxxxxxxx>

Thanks,

Ingo