Re: [PATCH 2/4] selftests, x86, protection_keys: remove dead code

From: Shuah Khan
Date: Thu Feb 02 2017 - 18:36:52 EST


On 02/02/2017 04:28 PM, Dave Hansen wrote:
> From: Shuah Khan <shuahkh@xxxxxxxxxxxxxxx>
>
> Remove commented out calls to pkey_get().
>
> Signed-off-by: Shuah Khan <shuahkh@xxxxxxxxxxxxxxx>
> Signed-off-by: Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>

Hi Dave,

This patches is already in linux-kselftest next for 4.11

Is there a reason why you chose to resend these.

-- Shuah

> ---
>
> b/tools/testing/selftests/x86/protection_keys.c | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff -puN tools/testing/selftests/x86/protection_keys.c~selftests-x86-protection-keys-remove-dead-code tools/testing/selftests/x86/protection_keys.c
> --- a/tools/testing/selftests/x86/protection_keys.c~selftests-x86-protection-keys-remove-dead-code 2017-02-02 15:27:13.329130196 -0800
> +++ b/tools/testing/selftests/x86/protection_keys.c 2017-02-02 15:27:13.333130376 -0800
> @@ -1114,11 +1114,6 @@ void test_pkey_syscalls_on_non_allocated
> err = sys_pkey_free(i);
> pkey_assert(err);
>
> - /* not enforced when pkey_get() is not a syscall
> - err = pkey_get(i, 0);
> - pkey_assert(err < 0);
> - */
> -
> err = sys_pkey_free(i);
> pkey_assert(err);
>
> @@ -1133,11 +1128,6 @@ void test_pkey_syscalls_bad_args(int *pt
> int err;
> int bad_pkey = NR_PKEYS+99;
>
> - /* not enforced when pkey_get() is not a syscall
> - err = pkey_get(bad_pkey, bad_flag);
> - pkey_assert(err < 0);
> - */
> -
> /* pass a known-invalid pkey in: */
> err = sys_mprotect_pkey(ptr, PAGE_SIZE, PROT_READ, bad_pkey);
> pkey_assert(err);
> _
>