Re: [PATCH 1/4] selftests, x86, protection_keys: fix unused variable compile warnings

From: Shuah Khan
Date: Thu Feb 02 2017 - 18:36:24 EST


On 02/02/2017 04:28 PM, Dave Hansen wrote:
> From: Shuah Khan <shuahkh@xxxxxxxxxxxxxxx>
>
> Fix unused variable compile warnings in protection_keys.c
>
> Signed-off-by: Shuah Khan <shuahkh@xxxxxxxxxxxxxxx>
> Signed-off-by: Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>

Hi Dave,

This patches is already in linux-kselftest next for 4.11

Is there a reason why you chose to resend these.

-- Shuah

> ---
>
> b/tools/testing/selftests/x86/protection_keys.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff -puN tools/testing/selftests/x86/protection_keys.c~selftests-x86-protection-keys-fix-unused-variable-compile-warnings tools/testing/selftests/x86/protection_keys.c
> --- a/tools/testing/selftests/x86/protection_keys.c~selftests-x86-protection-keys-fix-unused-variable-compile-warnings 2017-02-02 15:27:12.898110827 -0800
> +++ b/tools/testing/selftests/x86/protection_keys.c 2017-02-02 15:27:12.901110962 -0800
> @@ -812,8 +812,6 @@ void setup_hugetlbfs(void)
> {
> int err;
> int fd;
> - int validated_nr_pages;
> - int i;
> char buf[] = "123";
>
> if (geteuid() != 0) {
> @@ -1133,7 +1131,6 @@ void test_pkey_syscalls_on_non_allocated
> void test_pkey_syscalls_bad_args(int *ptr, u16 pkey)
> {
> int err;
> - int bad_flag = (PKEY_DISABLE_ACCESS | PKEY_DISABLE_WRITE) + 1;
> int bad_pkey = NR_PKEYS+99;
>
> /* not enforced when pkey_get() is not a syscall
> @@ -1149,8 +1146,6 @@ void test_pkey_syscalls_bad_args(int *pt
> /* Assumes that all pkeys other than 'pkey' are unallocated */
> void test_pkey_alloc_exhaust(int *ptr, u16 pkey)
> {
> - unsigned long flags;
> - unsigned long init_val;
> int err;
> int allocated_pkeys[NR_PKEYS] = {0};
> int nr_allocated_pkeys = 0;
> _
>