RE: [RFC PATCH] x86/CPU/AMD: Bring back Compute Unit ID

From: Ghannam, Yazen
Date: Wed Feb 01 2017 - 16:55:50 EST


> -----Original Message-----
> From: Borislav Petkov [mailto:bp@xxxxxxxxx]
> Sent: Wednesday, February 1, 2017 4:44 PM
>
> > To get around this we can set cu_id for all TOPOEXT systems, and update
> > cpu_core_id, etc. for SMT enabled systems. This way we can just change
> > cpu_core_id to cu_id in match_smt().
>
> Ok, so we want to init ->cu_id to something invalid then. -1, for
> example and then do:
>
> if (c->cu_id != -1 && o->cu_id != -1 && (c->cu_id == o->cu_id))
> ...
>
> Alternatively, we can define an X86_FEATURE_COMPUTE_UNITS or so
> synthetic bit which we can check.
>
> One thing I don't want to do is reuse ->cu_id on systems which don't
> have CUs.
>

Okay, in that case I would prefer to define a synthetic bit. I think it'll be a lot
more clear.

Thanks,
Yazen