Re: [PATCH v3] gpio: aspeed: Add banks Y, Z, AA, AB and AC

From: Andrew Jeffery
Date: Tue Jan 31 2017 - 20:20:35 EST


On Wed, 2017-02-01 at 11:22 +1030, Andrew Jeffery wrote:
> On Tue, 2017-01-31 at 15:50 +0100, Linus Walleij wrote:
> > > > > > On Fri, Jan 27, 2017 at 5:24 AM, Andrew Jeffery <andrew@xxxxxxxx> wrote:
> > > This is less straight-forward than one would hope, as some banks only
> > > have 4 pins rather than 8, others are output only, yet more (W and
> > > X, already supported) are input-only, and in the case of the g4 SoC bank
> > > AC doesn't exist.
> > >
> > > Add some structs to describe the varying properties of different banks
> > > and integrate mechanisms to deny requests for unsupported
> > > configurations.
> > >
> > > > > Signed-off-by: Andrew Jeffery <andrew@xxxxxxxx>
> > >
> > > ---
> > >
> > > Since v2:
> >
> > Patch applied with some patch -p1 < fuzz
> > please check the result.
>

*snip*

> Regardless, I'll try to recreate it myself and inspect the fuzz damage.

Ah, I think I see what's happened. I didn't send "gpio: aspeed: Make
bank names strings" again because you claimed you had applied v1 in the
v2 thread[1]. This patch doesn't fuzz when "gpio: aspeed: Make bank
names strings" has been applied, so is it possible that you tried
applying it to a tree missing "gpio: aspeed: Make bank names strings"?

$ git reset --hard gpio/for-next
HEAD is now at f334eae9c4e9 Merge branch 'devel' into for-next
$ git am "/home/andrew/patches/[PATCH_v2_1_2]_gpio:_aspeed:_Make_bank_names_strings.mbox"
Applying: gpio: aspeed: Make bank names strings
$ git am "/home/andrew/patches/[PATCH_v3]_gpio:_aspeed:_Add_banks_Y,_Z,_AA,_AB_and_AC.mbox"
Applying: gpio: aspeed: Add banks Y, Z, AA, AB and AC
$

Sorry for the confusion. What should I be doing when sending an updated
series where some of the patches have been applied? Send the whole
series regardless?

Andrew

[1] https://lkml.org/lkml/2017/1/26/334

Attachment: signature.asc
Description: This is a digitally signed message part