Re: [PATCH] regulator: cpcap: Add basic regulator support

[Mark Brown]

On Tue, Jan 31, 2017 at 02:09:53PM -0800, Tony Lindgren wrote:
> * Mark Brown <broonie@xxxxxxxxxx> [170131 13:14]:
> > On Mon, Jan 30, 2017 at 04:12:41PM -0800, Tony Lindgren wrote:
> > > +	error = regmap_update_bits(rdev->regmap, rdev->desc->enable_reg,
> > > +				   rdev->desc->enable_mask,
> > > +				   rdev->desc->enable_val);
> > > +	if (error)
> > > +		return error;
> > > +
> > > +	if (rdev->desc->enable_val & CPCAP_REG_OFF_MODE_SEC) {
> > > +		error = regmap_update_bits(rdev->regmap, regulator->assign_reg,
> > > +					   regulator->assign_mask,
> > > +					   regulator->assign_mask);
> > > +		if (error)
> > > +			return error;
> > > +	}

> > What does this second register bit do?

> My guess is that it triggers regulator idle modes in the PMIC based
> on the SoC off mode. There's no documentation for this thing..

> I've just kept what the Motorola Linux kernel tree does here and added
> some comments to CPCAP_REG_OFF_MODE_SEC.

> I'll address the rest of the comments and post v2, thanks for looking.

OK, thanks - comments should cover it here.

Attachment: signature.asc
Description: PGP signature