Re: [PATCH v3 20/24] media: imx: Add Camera Interface subdev driver

From: Ian Arkver
Date: Tue Jan 31 2017 - 17:34:57 EST


On 31/01/17 22:04, Russell King - ARM Linux wrote:
On Tue, Jan 31, 2017 at 09:55:29PM +0000, Ian Arkver wrote:
On 31/01/17 20:33, Russell King - ARM Linux wrote:
On Tue, Jan 31, 2017 at 10:21:26AM -0800, Steve Longerbeam wrote:
On 01/31/2017 05:42 AM, Russell King - ARM Linux wrote:
On Fri, Jan 20, 2017 at 03:38:28PM +0100, Hans Verkuil wrote:
Should be set to something like 'platform:imx-media-camif'. v4l2-compliance
should complain about this.
... and more.

Right, in version 3 that you are working with, no v4l2-compliance fixes were
in yet. A lot of the compliance errors are fixed, please look in latest
branch
imx-media-staging-md-wip at git@xxxxxxxxxx:slongerbeam/mediatree.git.

Sorry, I'm not prepared to pull random trees from github as there's
no easy way to see what's in the branch.

I've always disliked github because its web interface makes it soo
difficult to navigate around git trees hosted there. You can see
a commit, you can see a diff of the commit. You can get a list of
branches. But there seems to be no way to get a list of commits
similar to "git log" or even a one-line summary of each commit on
a branch. If there is, it's completely non-obvious (which I think is
much of the problem with github, it's web interface is horrendous.)

Or you can clone/pull the tree without knowing what you're fetching
(eg, what the tree is based upon.)

Or you can waste time clicking repeatedly on the "parent" commit link
on each patch working your way back through the history...

Well, it looks like it's bsaed on 4.10-rc1 with who-knows-what work
>from the linux-media tree (I didn't try and go back any further.)
As I don't want to take a whole pile of other changes into my tree,
I'm certainly not going to pull from your github tree. Sorry.


https://github.com/slongerbeam/mediatree/compare/master...imx-media-staging-md-wip

It's under the "Compare" button from the main view. It would be nice though
if the first commit's parent was some clearly tagged start point.

I don't want master though, I want v4.10-rc1, and if I ask for that
it tells me it knows nothing about v4.10-rc1, despite the fact that's
a tag in the mainline kernel repository which was merged into the
linux-media tree that this tree is based upon.


Yeah, that's what I meant about the first parent's commit not being a clearly tagged branch point. At least you get the series on one page. Maybe it's time for a rebase or a v4 series Steve?

Personally, I use a bare repo with multiple remotes and fetch branches from various trees. Then gitk --all --since(etc) is pretty good at giving the overview picture. You don't need to pull the commits over into any of your working branches if you don't want to.

Regards,
Ian