Re: [PATCH][net-next] sfc: fix an off-by-one compare on an array size

From: David Miller
Date: Tue Jan 31 2017 - 12:36:42 EST


From: Edward Cree <ecree@xxxxxxxxxxxxxx>
Date: Tue, 31 Jan 2017 16:37:10 +0000

> On 31/01/17 16:30, Colin King wrote:
>> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>>
>> encap_type should be checked to see if it is greater or equal to
>> the size of array map to fix an off-by-one array size check. This
>> fixes an array overrun read as detected by static analysis by
>> CoverityScan, CID#1398883 ("Out-of-bounds-read")
>>
>> Fixes: 9b41080125176841e ("sfc: insert catch-all filters for encapsulated traffic")
>> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> Good catch.
>
> Acked-by: Edward Cree <ecree@xxxxxxxxxxxxxx>

Applied, thanks everyone.