Re: [PATCH v2] xen-netfront: Fix Rx stall during network stress and OOM

From: Vineeth Remanan Pillai
Date: Tue Jan 31 2017 - 11:53:43 EST



On 01/30/2017 08:47 AM, Vineeth Remanan Pillai wrote:

On 01/29/2017 03:09 PM, Boris Ostrovsky wrote:

There are couple of problems with this patch.
1. The 'if' clause now evaluates to true on pretty much every call to xennet_alloc_rx_buffers().
Thanks for catching this. In my testing I did not notice this - mostly because of the nature of the workload in my testing.
I am working on a patch to revert to the old behavior and solve the Rx stall issue by scheduling the timer if any of the following
conditions are true:
- unconsumed requests + new requests < NET_RX_SLOTS_MIN (old behavior)
- skb allocations fail

Will send out the patch by next week after I can do some testing.

Thanks,
Vineeth