Re: [PATCH 1/2] device property: export code duplicating array of property entries

[Rafael J. Wysocki]

On 1/23/2017 11:46 PM, Dmitry Torokhov wrote:
> On Mon, Jan 23, 2017 at 05:00:38PM +0200, Andy Shevchenko wrote:
> > On Sun, 2017-01-22 at 23:38 -0800, Dmitry Torokhov wrote:
> > > When augmenting ACPI-enumerated devices with additional property data
> > > based
> > > on DMI info, a module has often several potential property sets, with
> > > only
> > > one being active on a given box. In order to save memory it should be
> > > possible to mark everything and __initdata or __initconst, execute DMI
> > > match early, and duplicate relevant properties. Then kernel will
> > > discard
> > > the rest of them.
> > Looks good to me.
> >
> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> >
> > Couple of style nitpicks.
> >
> > > +struct property_entry *property_entries_dup(
> > > +				const struct property_entry
> > > *properties)
> > Can we use
> >
> > struct propert_entry *
> > property_entries_dup(...)
> >
> > ?
> Sure, will adjust. I also realized we'll need property_entries_free()
> for proper cleanups. I'll repost the series.

Can you please CC it to linux-acpi while at that?  It will help to 
handle it.

Thanks,
Rafael