Re: [PATCH v6 3/5] cpuidle:powernv: Add helper function to populate powernv idle states.

[Gautham R Shenoy]

On Mon, Jan 30, 2017 at 10:17:50PM +1100, Michael Ellerman wrote:
> "Rafael J. Wysocki" <rafael@xxxxxxxxxx> writes:
> 
> > On Mon, Jan 30, 2017 at 4:47 AM, Michael Ellerman <mpe@xxxxxxxxxxxxxx> wrote:
> >> "Gautham R. Shenoy" <ego@xxxxxxxxxxxxxxxxxx> writes:
> >>
> >>> From: "Gautham R. Shenoy" <ego@xxxxxxxxxxxxxxxxxx>
> >>>
> >>> In the current code for powernv_add_idle_states, there is a lot of code
> >>> duplication while initializing an idle state in powernv_states table.
> >>>
> >>> Add an inline helper function to populate the powernv_states[] table
> >>> for a given idle state. Invoke this for populating the "Nap",
> >>> "Fastsleep" and the stop states in powernv_add_idle_states.
> >>>
> >>> Acked-by: Balbir Singh <bsingharora@xxxxxxxxx>
> >>> Signed-off-by: Gautham R. Shenoy <ego@xxxxxxxxxxxxxxxxxx>
> >>> ---
> >>>  drivers/cpuidle/cpuidle-powernv.c | 89 +++++++++++++++++++++++----------------
> >>>  include/linux/cpuidle.h           |  1 +
> >>
> >> I was going to merge this, but I see you've touched cpuidle.h, so I feel
> >> like I should get an ACK from the cpuidle folks.
> >>
> >> It's a fairly uncontroversial change, but it's their API.
> >
> > OK, please add an ACK from me to it then.
> 
> Thanks.

Thanks Rafael and Michal.

> 
> cheers
> 
--
Thanks and Regards
gautham.