Re: [PATCH] lightnvm: free properly on target creation error

[Matias BjÃrling]

On 01/26/2017 04:57 PM, Javier GonzÃlez wrote:
> Fix a memory leak when target creation fails. More specifically, free
> the entire device structure given to the target (tgt_dev).
> 
> Signed-off-by: Javier GonzÃlez <javier@xxxxxxxxxxxx>
> ---
>  drivers/lightnvm/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/lightnvm/core.c b/drivers/lightnvm/core.c
> index 8baae61..d5bb5e1 100644
> --- a/drivers/lightnvm/core.c
> +++ b/drivers/lightnvm/core.c
> @@ -309,7 +309,7 @@ static int nvm_create_tgt(struct nvm_dev *dev, struct nvm_ioctl_create *create)
>  err_queue:
>  	blk_cleanup_queue(tqueue);
>  err_dev:
> -	kfree(tgt_dev);
> +	nvm_remove_tgt_dev(tgt_dev);
>  err_t:
>  	kfree(t);
>  err_reserve:
> 

Thanks. Applied.