Re: [PATCH] i2c: piix4: Fix request_region size

From: Jean Delvare
Date: Sat Jan 28 2017 - 06:18:34 EST


Hi Wolfram,

On Sat, 28 Jan 2017 12:00:21 +0100, Wolfram Sang wrote:
>
> > > Â/* count for request_region */
> > > -#define SMBIOSIZE 8
> > > +#define SMBIOSIZE 9
> >
> > Are you certain that all supported devices have this extra register?
>
> Isn't it better to have a potentially unused register mapped than a
> potentially used register unmapped?

My concern is that the region request could fail due to a conflict with
another device, if the physical I/O region is only 8 and we try to
request 9.

--
Jean Delvare
SUSE L3 Support