Re: [PATCH 1/2] soc: samsung: pmu: Remove unused and duplicated defines

From: Krzysztof Kozlowski
Date: Thu Jan 26 2017 - 14:39:19 EST


On Thu, Jan 26, 2017 at 08:15:42AM +0100, Marek Szyprowski wrote:
> Hi Krzysztof,
>
>
> On 2017-01-25 20:34, Krzysztof Kozlowski wrote:
> > The exynos-regs-pmu.h was never a complete list of PMU registers. It
> > contained a lot of holes for registers which are not used. However, a
> > lot of unused defines came with porting the code from vendor kernel.
> >
> > Few of defines were also duplicated.
> >
> > Remove them so the file will be slightly smaller.
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
>
> Thanks for the cleanup!
>
> If you are touching this, you may also want to unify multiple headers for
> the Exynos PMU regs:
> include/linux/soc/samsung/exynos-regs-pmu.h
> linux/mfd/syscon/exynos4-pmu.h
> linux/mfd/syscon/exynos5-pmu.h
>
Sure, I'll take a look at these as well. Thanks for a hint.

Best regards,
Krzysztof