Re: [PATCHv6 06/37] thp: handle write-protection faults for file THP

From: Kirill A. Shutemov
Date: Thu Jan 26 2017 - 10:57:44 EST


On Thu, Jan 26, 2017 at 07:44:39AM -0800, Matthew Wilcox wrote:
> On Thu, Jan 26, 2017 at 02:57:48PM +0300, Kirill A. Shutemov wrote:
> > For filesystems that wants to be write-notified (has mkwrite), we will
> > encount write-protection faults for huge PMDs in shared mappings.
> >
> > The easiest way to handle them is to clear the PMD and let it refault as
> > wriable.
>
> ... of course, the filesystem could implement ->pmd_fault, and then it
> wouldn't hit this case ...

I would rather get rid of ->pmd_fault/->huge_fault :)

->fault should be flexible enough to provide for all of them...

--
Kirill A. Shutemov