Re: [PATCH RESEND] pinctrl: intel: Turn Baytrail support to tristate

From: Andy Shevchenko
Date: Wed Jan 25 2017 - 11:15:16 EST


On Wed, Jan 25, 2017 at 5:26 PM, Jean Delvare <jdelvare@xxxxxxx> wrote:
> The pinctrl-baytrail driver builds just fine as a module so give
> users this option.
>
> Signed-off-by: Jean Delvare <jdelvare@xxxxxxx>
> Cc: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
> Cc: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>
> Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>

Looks okay to me.
FWIW:
Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>

> ---
> This was discussed almost one year ago, with no clear conclusion, but
> also no evidence that the driver can't be built as a module. Is there
> any way to push this forward?
>
> drivers/pinctrl/intel/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-4.7-rc7.orig/drivers/pinctrl/intel/Kconfig 2016-07-12 14:35:36.024835842 +0200
> +++ linux-4.7-rc7/drivers/pinctrl/intel/Kconfig 2016-07-12 14:35:44.735904433 +0200
> @@ -3,7 +3,7 @@
> #
>
> config PINCTRL_BAYTRAIL
> - bool "Intel Baytrail GPIO pin control"
> + tristate "Intel Baytrail GPIO pin control"
> depends on GPIOLIB && ACPI
> select GPIOLIB_IRQCHIP
> select PINMUX
>
>
> --
> Jean Delvare
> SUSE L3 Support



--
With Best Regards,
Andy Shevchenko