Re: [PATCH] kasan: Respect /proc/sys/kernel/traceoff_on_warning

[Alexander Potapenko]

On Wed, Jan 25, 2017 at 3:35 PM, Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
> On Wed, Jan 25, 2017 at 03:32:11PM +0100, Alexander Potapenko wrote:
>
>> > @@ -300,6 +301,8 @@ void kasan_report(unsigned long addr, size_t size,
>> >         if (likely(!kasan_report_enabled()))
>> >                 return;
>> >
>> > +       disable_trace_on_warning();
>> > +
>> Who is going to enable tracing back after we're done?
>
> The user..
>
>> Note that KASAN errors are not fatal, and the first one may possibly
>> occur quite early.
>
> WARN*() isn't fatal either, and it does the same thing. Note that
> traceoff_on_warning is default disabled. You have to explicitly request
> this.
Ah, that makes sense. Sorry, I wasn't aware of that interface before.



-- 
Alexander Potapenko
Software Engineer

Google Germany GmbH
Erika-Mann-StraÃe, 33
80636 MÃnchen

GeschÃftsfÃhrer: Matthew Scott Sucherman, Paul Terence Manicle
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg