Re: [PATCH v3] HWPOISON: soft offlining for non-lru movable page

[Michal Hocko]

On Wed 25-01-17 12:47:53, Michal Hocko wrote:
> On Mon 23-01-17 22:50:10, ysxie@xxxxxxxxxxx wrote:
> > From: Yisheng Xie <xieyisheng1@xxxxxxxxxx>
> > 
> > This patch is to extends soft offlining framework to support
> > non-lru page, which already support migration after
> > commit bda807d44454 ("mm: migrate: support non-lru movable page
> > migration")
> > 
> > When memory corrected errors occur on a non-lru movable page,
> > we can choose to stop using it by migrating data onto another
> > page and disable the original (maybe half-broken) one.
> > 
> > Signed-off-by: Yisheng Xie <xieyisheng1@xxxxxxxxxx>
> > Suggested-by: Michal Hocko <mhocko@xxxxxxxxxx>
> > Suggested-by: Minchan Kim <minchan@xxxxxxxxxx>
> > Acked-by: Naoya Horiguchi <n-horiguchi@xxxxxxxxxxxxx>
> 
> This doesn't compile with CONFIG_MIGRATION=n
> 
> mm/memory-failure.c: In function '__soft_offline_page':
> mm/memory-failure.c:1656:3: error: implicit declaration of function 'isolate_movable_page' [-Werror=implicit-function-declaration]
>    ret = !isolate_movable_page(page, ISOLATE_UNEVICTABLE);
>    ^
> cc1: some warnings being treated as errors

OK, I have missed
http://lkml.kernel.org/r/1485340563-60785-1-git-send-email-xieyisheng1@xxxxxxxxxx
so please scratch this one.

-- 
Michal Hocko
SUSE Labs