Re: [STLinux Kernel] [PATCH 6/8] ARM: dts: STiH407-pinctrl: Add Pinctrl group for HW flow-control

From: Peter Griffin
Date: Wed Jan 25 2017 - 06:01:21 EST


Hi Lee,

On Tue, 24 Jan 2017, Lee Jones wrote:

> Each serial port which supports HW flow-control should have 2 Pinctrl
> groups. Once for when HW flow-control is in progress, where the IP

Nit: Once?

> will take over controlling the lines and another group which enables
> the lines to be toggled using GPIO mechanisms.
>
> Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>

Acked-by: Peter Griffin <peter.griffin@xxxxxxxxxx>

> ---
> arch/arm/boot/dts/stih407-pinctrl.dtsi | 12 ++++++++++--
> 1 file changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/stih407-pinctrl.dtsi b/arch/arm/boot/dts/stih407-pinctrl.dtsi
> index daab16b..fbb7f86 100644
> --- a/arch/arm/boot/dts/stih407-pinctrl.dtsi
> +++ b/arch/arm/boot/dts/stih407-pinctrl.dtsi
> @@ -465,8 +465,16 @@
> serial0 {
> pinctrl_serial0: serial0-0 {
> st,pins {
> - tx = <&pio17 0 ALT1 OUT>;
> - rx = <&pio17 1 ALT1 IN>;
> + tx = <&pio17 0 ALT1 OUT>;
> + rx = <&pio17 1 ALT1 IN>;
> + };
> + };
> + pinctrl_serial0_flowctrl: serial0-0_flowctrl {
> + st,pins {
> + tx = <&pio17 0 ALT1 OUT>;
> + rx = <&pio17 1 ALT1 IN>;
> + cts = <&pio17 2 ALT1 IN>;
> + rts = <&pio17 3 ALT1 OUT>;
> };
> };
> };