Re: [PATCH v2] virtio_net: fix PAGE_SIZE > 64k

From: David Miller
Date: Tue Jan 24 2017 - 14:43:05 EST


From: "Michael S. Tsirkin" <mst@xxxxxxxxxx>
Date: Mon, 23 Jan 2017 21:37:52 +0200

> I don't have any guests with PAGE_SIZE > 64k but the
> code seems to be clearly broken in that case
> as PAGE_SIZE / MERGEABLE_BUFFER_ALIGN will need
> more than 8 bit and so the code in mergeable_ctx_to_buf_address
> does not give us the actual true size.
>
> Cc: John Fastabend <john.fastabend@xxxxxxxxx>
> Signed-off-by: Michael S. Tsirkin <mst@xxxxxxxxxx>

Applied, thanks Michael.

I am really trying to be patient, but we are about to run out of
time for fixing the adjust header XDP stuff.

That should have been resolved in a week or two, but now we're
basically a month or so later.

Please come to some kind of agreement about how to implement this
because we can't let v4.10 go out without this being resolved.

Thank you.