Re: [PATCH net-next v5] bridge: multicast to unicast

From: Stephen Hemminger
Date: Tue Jan 24 2017 - 13:12:38 EST


On Sat, 21 Jan 2017 21:01:32 +0100
Linus LÃssing <linus.luessing@xxxxxxxxx> wrote:

> +static bool br_port_group_equal(struct net_bridge_port_group *p,
> + struct net_bridge_port *port,
> + const unsigned char *src)
> +{
> + if (p->port != port)
> + return false;
> +
> + if (!(port->flags & BR_MULTICAST_TO_UNICAST))
> + return true;
> +
> + return ether_addr_equal(src, p->eth_addr);
> +}
> +

I prefer that argument to functions like this be const.