Re: [PATCH 1/1] EDAC: always return an initialized value in knl_show_interleave_mode

From: Borislav Petkov
Date: Sun Jan 22 2017 - 11:10:51 EST


On Sun, Jan 22, 2017 at 04:50:31PM +0100, Nicolas Iooss wrote:
> if (!is_knl)
> return interleave_mode(reg) ?
> "[8:6]" : "[8:6]XOR[18:16]";
> else
> return knl_intlv_mode[knl_interleave_mode(reg)];
>
> Would this be good for you?

Ah, yes we interleave on address bits [8:6] when the bitield is 0 on KNL
while bitfield 0 for the rest of the families gives interleave mode for
the XOR of bits [8:6] and [18:16]. Good catch.

Thanks.

--
Regards/Gruss,
Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.