Re: [PATCH 1/2] i2c: mux: pca954x: Export OF device ID table as module aliases

From: Peter Rosin
Date: Sat Jan 21 2017 - 10:57:54 EST


On 2017-01-16 14:54, Javier Martinez Canillas wrote:
> The I2C core always reports a MODALIAS of the form i2c:<foo> even if the
> device was registered via OF, this means that exporting the OF device ID
> table device aliases in the module is not needed. But in order to change
> how the core reports modaliases to user-space, it's better to export it.
>
> Signed-off-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx>

Acked-by: Peter Rosin <peda@xxxxxxxxxx>

> ---
>
> drivers/i2c/muxes/i2c-mux-pca954x.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/i2c/muxes/i2c-mux-pca954x.c b/drivers/i2c/muxes/i2c-mux-pca954x.c
> index dd18b9ccb1f4..a0232e079545 100644
> --- a/drivers/i2c/muxes/i2c-mux-pca954x.c
> +++ b/drivers/i2c/muxes/i2c-mux-pca954x.c
> @@ -148,6 +148,7 @@ static const struct of_device_id pca954x_of_match[] = {
> { .compatible = "nxp,pca9548", .data = &chips[pca_9548] },
> {}
> };
> +MODULE_DEVICE_TABLE(of, pca954x_of_match);
> #endif
>
> /* Write to mux register. Don't use i2c_transfer()/i2c_smbus_xfer()
>