Re: [PATCH 02/17] HID: logitech-hidpp: Add scope to battery

From: Jiri Kosina
Date: Fri Jan 20 2017 - 08:43:57 EST


On Tue, 17 Jan 2017, Benjamin Tissoires wrote:

> From: Bastien Nocera <hadess@xxxxxxxxxx>
>
> Without a scope defined, UPower assumes that the battery is provide
> power to the computer it's connected to, like a laptop battery or a UPS.
>
> Tested-by: Peter Hutterer <peter.hutterer@xxxxxxxxx>
> Signed-off-by: Bastien Nocera <hadess@xxxxxxxxxx>
> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx>
> ---
> drivers/hid/hid-logitech-hidpp.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c
> index 4eeb550..4aaf237 100644
> --- a/drivers/hid/hid-logitech-hidpp.c
> +++ b/drivers/hid/hid-logitech-hidpp.c
> @@ -761,6 +761,7 @@ static int hidpp20_battery_event(struct hidpp_device *hidpp,
> static enum power_supply_property hidpp_battery_props[] = {
> POWER_SUPPLY_PROP_STATUS,
> POWER_SUPPLY_PROP_CAPACITY,
> + POWER_SUPPLY_PROP_SCOPE,

Actually, what is the code baseline for this patchset please? I don't
think I've ever seen hidpp_battery_props[] before.

Thanks,

--
Jiri Kosina
SUSE Labs