Re: [PATCH v4 2/5] ia64: reuse append_elf_note() and final_note() functions

From: Michael Ellerman
Date: Fri Jan 20 2017 - 00:47:53 EST


Hari Bathini <hbathini@xxxxxxxxxxxxxxxxxx> writes:

> Get rid of multiple definitions of append_elf_note() & final_note()
> functions. Reuse these functions compiled under CONFIG_CRASH_CORE
> Also, define Elf_Word and use it instead of generic u32 or the more
> specific Elf64_Word.
>
> Signed-off-by: Hari Bathini <hbathini@xxxxxxxxxxxxxxxxxx>
> ---
>
> Changes from v3:
> * Dropped hard-coded values and used DIV_ROUND_UP().
>
> Changes from v2:
> * Added a definition for Elf_Word.
> * Used IA64 version of append_elf_note() and final_note() functions.
>
>
> arch/ia64/kernel/crash.c | 22 ----------------------
> include/linux/crash_core.h | 4 ++++
> include/linux/elf.h | 2 ++
> kernel/crash_core.c | 34 ++++++++++++++--------------------
> kernel/kexec_core.c | 28 ----------------------------
> 5 files changed, 20 insertions(+), 70 deletions(-)

Do the powerpc patches later in the series actually depend on this one?
Or is this just an unrelated cleanup?

As it is I can't merge the series until we at least get an ack on this
from the ia64 folks.

If you can just split this out as a separate patch that would make it a
lot easier to get the rest merged.

cheers