Re: [PATCH perf/core 2/6] tools lib bpf: Fix grammar in map_idx warning

[Wangnan (F)]

On 2017/1/19 7:57, Joe Stringer wrote:
> "Larger" is the comparative adjective form of "large".
>
> Signed-off-by: Joe Stringer <joe@xxxxxxx>
> ---
>   tools/lib/bpf/libbpf.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c
> index 350ee4c59f85..653b1b368deb 100644
> --- a/tools/lib/bpf/libbpf.c
> +++ b/tools/lib/bpf/libbpf.c
> @@ -834,7 +834,7 @@ bpf_program__collect_reloc(struct bpf_program *prog,
>   
>   		map_idx = sym.st_value / prog->obj->map_len;
>   		if (map_idx >= nr_maps) {
> -			pr_warning("bpf relocation: map_idx %d large than %d\n",
> +			pr_warning("bpf relocation: map_idx %d larger than %d\n",

With my change to 1/6, this message become meaningless. We can
change it to:

    bpf relocation: failed to relocate instruction %u

Thank you.

>   				   (int)map_idx, (int)nr_maps - 1);
>   			return -LIBBPF_ERRNO__RELOC;
>   		}