Re: [PATCHv2 7/7] IPVTAP: IP-VLAN based tap driver

From: David Miller
Date: Wed Jan 18 2017 - 16:28:54 EST


From: Sainath Grandhi <sainath.grandhi@xxxxxxxxx>
Date: Tue, 17 Jan 2017 16:03:06 -0800

> +static void ipvtap_count_tx_dropped(struct tap_dev *tap)
> +{
> + struct ipvl_dev *vlan = (struct ipvl_dev *)container_of(tap, struct ipvtap_dev, tap);
...
> +static void ipvtap_count_rx_dropped(struct tap_dev *tap)
> +{
> + struct ipvl_dev *vlan = (struct ipvl_dev *)container_of(tap, struct ipvtap_dev, tap);
...
> +static void ipvtap_update_features(struct tap_dev *tap,
> + netdev_features_t features)
> +{
> + struct ipvl_dev *vlan = (struct ipvl_dev *)container_of(tap, struct ipvtap_dev, tap);

More unnecessary casts, please remove.