Re: [PATCH v2] xen-netfront: Fix Rx stall during network stress and OOM

From: Vineeth Remanan Pillai
Date: Wed Jan 18 2017 - 12:10:47 EST



On 01/15/2017 10:24 PM, Juergen Gross wrote:
On 13/01/17 18:55, Remanan Pillai wrote:
From: Vineeth Remanan Pillai <vineethp@xxxxxxxxxx>

During an OOM scenario, request slots could not be created as skb
allocation fails. So the netback cannot pass in packets and netfront
wrongly assumes that there is no more work to be done and it disables
polling. This causes Rx to stall.

The issue is with the retry logic which schedules the timer if the
created slots are less than NET_RX_SLOTS_MIN. The count of new request
slots to be pushed are calculated as a difference between new req_prod
and rsp_cons which could be more than the actual slots, if there are
unconsumed responses.

The fix is to calculate the count of newly created slots as the
difference between new req_prod and old req_prod.

Signed-off-by: Vineeth Remanan Pillai <vineethp@xxxxxxxxxx>
Reviewed-by: Juergen Gross <jgross@xxxxxxxx>
Thanks Juergen.

David,

Could you please pick up this change for net-next if there no more concerns..

Many Thanks,
Vineeth



Thanks,

Juergen