Re: [PATCH 4/4] alpha: Move two assignments for the variable "res" in srm_env_proc_write()

From: Jan-Benedict Glaw
Date: Wed Jan 18 2017 - 08:33:24 EST


On Wed, 2017-01-18 12:50:17 +0100, SF Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> wrote:
> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> Date: Wed, 18 Jan 2017 12:08:44 +0100
>
> A local variable was set to an error code in two cases before a concrete
> error situation was detected. Thus move the corresponding assignment into
> an if branch to indicate a software failure there.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
Acked-by: Jan-Benedict Glaw <jbglaw@xxxxxxxxxx>

MfG, JBG

--
Jan-Benedict Glaw jbglaw@xxxxxxxxxx +49-172-7608481
Signature of: http://www.chiark.greenend.org.uk/~sgtatham/bugs.html
the second :

Attachment: signature.asc
Description: Digital signature