Re: [PATCH 2/2] perf/core: Remove perf_cpu_context::unique_pmu

From: Mark Rutland
Date: Wed Jan 18 2017 - 07:26:21 EST


On Tue, Jan 17, 2017 at 09:38:40AM -0800, David Carrillo-Cisneros wrote:
> cpuctx->unique_pmu was originally introduced as a way to identify cpuctxs
> with shared pmus in order to avoid visiting the same cpuctx more than once
> in a for_each_pmu loop.
>
> cpuctx->unique_pmu == cpuctx->pmu in non-software task contexts since they
> have only one pmu per cpuctx. Since perf_pmu_sched_task is only called in
> hw contexts, this patch replaces cpuctx->unique_pmu by cpuctx->pmu in it.
>
> The change above, together with the previous patch in this series, removed
> the remaining uses of cpuctx->unique_pmu, so we remove it altogether.
>
> Signed-off-by: David Carrillo-Cisneros <davidcc@xxxxxxxxxx>

I don't have any HW with a PMU that needs a sched_task callback, so I'm
unable to give this a full test, but it looks sane to me. FWIW:

Acked-by: Mark Rutland <mark.rutland@xxxxxxx>

Thanks,
Mark.