Re: [PATCH net-next v4 05/10] drivers: base: Add device_find_in_class_name()

From: Andy Shevchenko
Date: Tue Jan 17 2017 - 19:00:54 EST


On Wed, Jan 18, 2017 at 1:43 AM, Florian Fainelli <f.fainelli@xxxxxxxxx> wrote:
> On 01/17/2017 03:34 PM, Andy Shevchenko wrote:
>> On Wed, Jan 18, 2017 at 1:21 AM, Florian Fainelli <f.fainelli@xxxxxxxxx> wrote:

>>> +static int device_class_name_match(struct device *dev, void *class)
>>
>> And why not const char *class?
>
> This was raised back in v2, and the same response applies:
>
> https://www.mail-archive.com/netdev@xxxxxxxxxxxxxxx/msg147559.html
>
> Changing the signature of a callback is out of the scope of this patch
> series.

Ah, right.

But why not to use void *class_name to be consistent with callback and
device_find_child()?

Btw,

return get_device(parent);

--
With Best Regards,
Andy Shevchenko