Re: [PATCH 1/3] Input: add STMicroelectronics FingerTip touchscreen driver

From: Krzysztof Kozlowski
Date: Tue Jan 17 2017 - 13:52:43 EST


On Tue, Jan 17, 2017 at 10:54:39PM +0900, Andi Shyti wrote:
> Add binding for the STMicroelectronics FingerTip (stmfts)
> touchscreen driver.
>
> Signed-off-by: Andi Shyti <andi.shyti@xxxxxxxxxxx>
> ---
> .../bindings/input/touchscreen/st,stmfts.txt | 43 ++++++++++++++++++++++
> 1 file changed, 43 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/input/touchscreen/st,stmfts.txt
>
> diff --git a/Documentation/devicetree/bindings/input/touchscreen/st,stmfts.txt b/Documentation/devicetree/bindings/input/touchscreen/st,stmfts.txt
> new file mode 100644
> index 000000000000..788f4ba744db
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/touchscreen/st,stmfts.txt
> @@ -0,0 +1,43 @@
> +* ST-Microelectronics FingerTip touchscreen controller
> +
> +The ST-Microelectronics FingerTip device provides a basic touchscreen
> +functionality. Along with it the user can enable the touchkey which can work as
> +a basic HOME and BACK key for phones.
> +
> +The driver supports also hovering as an absolute single touch event with x, y, z
> +coordinates.
> +
> +Required properties:
> +- compatible : must be "st,stmfts"
> +- reg : I2C slave address, (e.g. 0x49)
> +- interrupt-parent : the phandle to the interrupt controller which provides
> + the interrupt
> +- interrupts : interrupt specification
> +- avdd-supply : analogic power supply
> +- vdd-supply : power supply
> +- touchscreen-size-x : see touchscreen.txt
> +- touchscreen-size-y : see touchscreen.txt
> +
> +Optional properties:
> +- touch-key-connected : specifies whether the touchkey feature is connected

You are making it a generic property but it is specific to this device,
so:
st,touch-key-connected
?

> +- ledvdd-supply : power supply to the touch key leds

Is this really optional? If yes... how it gets the power when not
provided?

Best regards,
Krzysztof

> +
> +Example:
> +
> +i2c@00000000 {
> +
> + /* ... */
> +
> + stmfts@49 {
> + compatible = "st,stmfts";
> + reg = <0x49>;
> + interrupt-parent = <&gpa1>;
> + interrupts = <1 IRQ_TYPE_NONE>;
> + touchscreen-size-x = <1599>;
> + touchscreen-size-y = <2559>;
> + touch-key-connected;
> + avdd-supply = <&ldo30_reg>;
> + vdd-supply = <&ldo31_reg>;
> + ledvdd-supply = <&ldo33_reg>;
> + };
> +};
> --
> 2.11.0
>