Re: mwifiex: debugfs: Fix (sometimes) off-by-1 SSID print

From: Kalle Valo
Date: Tue Jan 17 2017 - 07:06:26 EST


Brian Norris <briannorris@xxxxxxxxxxxx> wrote:
> Similar to commit fcd2042e8d36 ("mwifiex: printk() overflow with 32-byte
> SSIDs"), we failed to account for the existence of 32-char SSIDs in our
> debugfs code. Unlike in that case though, we zeroed out the containing
> struct first, and I'm pretty sure we're guaranteed to have some padding
> after the 'ssid.ssid' and 'ssid.ssid_len' fields (the struct is 33 bytes
> long).
>
> So, this is the difference between:
>
> # cat /sys/kernel/debug/mwifiex/mlan0/info
> ...
> essid="0123456789abcdef0123456789abcdef "
> ...
>
> and the correct output:
>
> # cat /sys/kernel/debug/mwifiex/mlan0/info
> ...
> essid="0123456789abcdef0123456789abcdef"
> ...
>
> Fixes: 5e6e3a92b9a4 ("wireless: mwifiex: initial commit for Marvell mwifiex driver")
> Signed-off-by: Brian Norris <briannorris@xxxxxxxxxxxx>

Patch applied to wireless-drivers-next.git, thanks.

6183468a23fc mwifiex: debugfs: Fix (sometimes) off-by-1 SSID print

--
https://patchwork.kernel.org/patch/9506069/

Documentation about submitting wireless patches and checking status
from patchwork:

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches