Re: [PATCH 1/4] mm, page_alloc: do not report all nodes in show_mem

From: Hillf Danton
Date: Tue Jan 17 2017 - 04:33:21 EST



On Tuesday, January 17, 2017 5:16 PM Michal Hocko wrote:
>
> From: Michal Hocko <mhocko@xxxxxxxx>
>
> 599d0c954f91 ("mm, vmscan: move LRU lists to node") has added per numa
> node statistics to show_mem but it forgot to add skip_free_areas_node
> to fileter out nodes which are outside of the allocating task numa
> policy. Add this check to not pollute the output with the pointless
> information.
>
> Acked-by: Mel Gorman <mgorman@xxxxxxx>
> Acked-by: Johannes Weiner <hannes@xxxxxxxxxxx>
> Signed-off-by: Michal Hocko <mhocko@xxxxxxxx>
> ---
Acked-by: Hillf Danton <hillf.zj@xxxxxxxxxxxxxxx>

> mm/page_alloc.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 8ff25883c172..8f4f306d804c 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -4345,6 +4345,9 @@ void show_free_areas(unsigned int filter)
> global_page_state(NR_FREE_CMA_PAGES));
>
> for_each_online_pgdat(pgdat) {
> + if (skip_free_areas_node(filter, pgdat->node_id))
> + continue;
> +
> printk("Node %d"
> " active_anon:%lukB"
> " inactive_anon:%lukB"
> --
> 2.11.0